Issue metadata
Sign in to add a comment
|
26.4%-54.1% regression in v8.google at 401854:401910 |
||||||||||||||||||||||
Issue descriptionI suspect http://crrev.com/2084913006 might have something to do with this. Please reassign if you think it's unrelated.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/70318619905dd1a10ac0f063da19cebf6d385ba0 commit 70318619905dd1a10ac0f063da19cebf6d385ba0 Author: ishell <ishell@chromium.org> Date: Tue Jun 28 16:15:18 2016 [ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata. The serializer does not support serialization of HashTables in general because after deserialization it might be necessary to rehash the table. However the UnseededNumberDictionary does not require rehashing and this CL allows them to be serialized. This CL also changes the shape of UnseededNumberDictionary: the details field is no longer part of the entry since no one needs it. BUG=chromium:576312, chromium:623516 Review-Url: https://codereview.chromium.org/2102073002 Cr-Commit-Position: refs/heads/master@{#37336} [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/heap/heap.cc [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/heap/heap.h [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/objects-inl.h [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/objects.cc [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/objects.h [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/type-feedback-vector.cc [modify] https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0/src/type-info.cc
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ab7234a49260483fd8ac8e051377604bbebe5a8d commit ab7234a49260483fd8ac8e051377604bbebe5a8d Author: ishell <ishell@chromium.org> Date: Tue Jun 28 17:56:41 2016 [ic] Move sloppy_arguments_elements_map down in the root list. Addressing comment in https://codereview.chromium.org/2102073002/ BUG=chromium:576312, chromium:623516 Review-Url: https://codereview.chromium.org/2109713002 Cr-Commit-Position: refs/heads/master@{#37343} [modify] https://crrev.com/ab7234a49260483fd8ac8e051377604bbebe5a8d/src/heap/heap.h
,
Jun 30 2016
,
Jun 30 2016
,
Sep 22 2016
This seems to not have been backmerged to M53 causing some serious regression on adwords.
,
Sep 22 2016
,
Sep 22 2016
Please merge to 53
,
Sep 22 2016
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2e706ff77829c8252ba72c9f2b3e558b0533282a commit 2e706ff77829c8252ba72c9f2b3e558b0533282a Author: Michael Hablich <hablich@chromium.org> Date: Thu Sep 22 16:10:27 2016 Merged: Squashed multiple commits. Merged: [ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata. Revision: 70318619905dd1a10ac0f063da19cebf6d385ba0 Merged: [ic] Move sloppy_arguments_elements_map down in the root list. Revision: ab7234a49260483fd8ac8e051377604bbebe5a8d BUG=chromium:576312,chromium:576312, chromium:623516 , chromium:623516 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=cbruni@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/2367493002 . Cr-Commit-Position: refs/branch-heads/5.3@{#71} Cr-Branched-From: 820a23aade5e74a92d794e05a0c2b3597f0da4b5-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb2c1b4d75c41af386cb4fedbe5566f5608-refs/heads/master@{#37308} [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/heap/heap.cc [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/heap/heap.h [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/objects-inl.h [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/objects.cc [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/objects.h [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/type-feedback-vector.cc [modify] https://crrev.com/2e706ff77829c8252ba72c9f2b3e558b0533282a/src/type-info.cc
,
Sep 22 2016
,
Sep 22 2016
This needs to be on the next stable refresh. On M54 this is already fixed.
,
Sep 27 2016
Can we get a postmortem on how we missed this for the initial stables?
,
Sep 28 2016
Shared it with you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by epertoso@chromium.org
, Jun 27 2016