New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623496 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : In chrome://site-engagement, table gets closed after clicking on 'Origin' sory key.

Reported by yfulgaon...@etouch.net, Jun 27 2016

Issue description

Chrome version : 53.0.2780.0 (Official Build) 5453dc6abc2d7c797c7f9f16df8aed8e6358a217-refs/heads/master@{#402053} 32/64 bit
OS :  Windows (7,8,8.1,10), Linux(14.04 LTS), Mac(10.10.5, 10.11.4)

Test URLs : 
1. www.google.com
2. www.gmail.com

What steps will reproduce the problem?
1) Launch chrome and open Test URL 1 & 2 in two different tabs.
2) Go to chrome://site-engagement/ and click on 'Origin' sort key, observe.

Actual : After clicking on 'Origin' sort key, table gets closed.
Expected : After clicking on 'Origin' sort key, table should not get closed and all records should get sorted.

This is a regression issue, broken in 'M-53' and below is the Manual regression and Narrow Bisect info.
Good Build : 53.0.2774.2
Bad Build : 53.0.2776.0

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/1201e5870ce0bcbb9e31518fcbc2ac2635d07187..e05337aecafcfb492a346acf8de444e8140da469?pretty=fuller&n=10000

Suspecting : r400900 from Narrow Bisect

 
Actual_site_engagement.mp4
1.1 MB View Download
Expected_site-engagement.mp4
851 KB View Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be40699a2e41dbd92b3d5d8ea0d4ad4d659916f3

commit be40699a2e41dbd92b3d5d8ea0d4ad4d659916f3
Author: sammc <sammc@chromium.org>
Date: Wed Jun 29 08:51:29 2016

Construct URLs from the url field when sorting site engagement by origin.

BUG= 623496 

Review-Url: https://codereview.chromium.org/2104783002
Cr-Commit-Position: refs/heads/master@{#402756}

[modify] https://crrev.com/be40699a2e41dbd92b3d5d8ea0d4ad4d659916f3/chrome/browser/resources/engagement/site_engagement.js

Comment 3 by sa...@chromium.org, Jun 30 2016

Status: Fixed (was: Assigned)

Sign in to add a comment