New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623492 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox has overly narrow clipping when focused

Project Member Reported by sascha@google.com, Jun 27 2016

Issue description

Chrome Version       : 51.0.2704.103
OS Version: OS X 10.11.5
URLs (if applicable) :
Other browsers tested:
  Safari 9.1.1: OK (=less clipping than in Chrome 51, so text is easier to read)
  Firefox 47:   FAIL (=clipping is as bad as Chrome 51)

What steps will reproduce the problem?
1. Enter సై స్తై స్తె into the address/search bar

What is the expected result?
The low-hanging parts of the text should still be readable, to the extent possible.

What happens instead of that?
When the address/search box is focused, Chrome uses a smaller clip box than when un-focused. Therefore, in the focused view, most pixels in the lower parts of the entered Telugu text are getting clipped off. To make the text better readable, the address/search bar should use the unfocused clipping box also in its focused state.

See attached screenshots for focused vs. unfocused in Chrome.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

 
Chrome-Focused.png
51.8 KB View Download
Chrome-Unfocused.png
52.1 KB View Download

Comment 1 by sascha@google.com, Jun 27 2016

Could the Omnibox grow when the entered text doesn’t fit?
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 27 2016

Labels: Hotlist-Google

Comment 3 by mmenke@chromium.org, Jun 27 2016

Components: UI>Browser>Omnibox
Cc: sh...@chromium.org
Owner: andresantoso@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to andresantoso@ because this sounds like a previous  bug 528845  that was also assigned to him.

Note shess@'s interesting comment #6 on that bug explaining the issues with Hindi fonts' bounding boxes.

Also CC shess@ as an FYI.

Comment 5 by sh...@chromium.org, Jun 27 2016

I see the report is marked restricted - anyone have issues with removing that?  If nobody responds I'll remove it :-).

WRT growing the Omnibox, that's probably a non-starter, because it's likely to have tons of unacceptable edge cases which would only affect a small subset of users, so it probably wouldn't get picked up as a high-priority problem.

If I had all the resources in the world, I'd probably aim to have the omnibox control editor somehow setup to have a gradient bounding box.  Like it would have a strong bound at the focus ring, and a somewhat-transparent pixel within that, then full-transparent within that.

This would also require some work on the selection box, I think.  Not because it needs to select the boundaries of the text, rather I seem to recall once trying to loosen the bounding box in there and finding that the selection box expands to fill.  For text following the ASCII bounding box, this would look rather unbalanced.  I suspect getting the selection box right for all comers might be challenging.

That said, the OSX text-control system is subtle, and quick to anger.  Would MacViews provide an alternative where all platforms are correct (or broken) in similar fashion?

Comment 6 by sh...@chromium.org, Jun 27 2016

I meant "Tons of unacceptable edge cases for a feature to only benefit a small subset of users".  Basically, I'd hate to generate complicated bugs for everyone for something which will provide poor benefits to a small number of users (I'm not meaning a value judgement, just trying to reflect reality, editing in a field with specific UI goals which works for all scripts is challenging when few of the engineers understand the subtle aspects).
Growing the omnibox is an eventual must-have anyway for a11y, at least on views.  I would suggest planning to do it.

Comment 8 by sascha@google.com, Jun 30 2016

> report is marked restricted
Oh, that was not intentional.


Comment 9 by js...@chromium.org, Sep 20 2016

Labels: allpublic
>> report is marked restricted
> Oh, that was not intentional.

It's crbug doing that automatically under certain conditions. Opening up this bug to the public. 

Comment 10 by js...@chromium.org, Sep 20 2016

> Growing the omnibox is an eventual must-have anyway for a11y, at least on views.  
> I would suggest planning to do it.

That's welcome news :-). We're talking about potentially a billion of (potential) users (South Asia alone). 
In fairness, this bug is marked as Mac-specific, there's no way way a Mac bug affects a billion people.

Not that we shouldn't fix.
Owner: shrike@chromium.org
Cc: shrike@chromium.org
Labels: Hotlist-Polish
Owner: spqc...@chromium.org
spqchan@ - it looks like this is still happening in Material Design. Can you take a look at this to see what needs to happen to clip less of the text when editing? And also what we need to do to clip a little more of the text when not editing (the text should not overlap the omnibox border).
FYI, still reproduces in Chrome 58.
Labels: -Hotlist-Polish Hotlist-PlatformExcellence
Cc: -shrike@chromium.org
Labels: Hotlist-CocoaBrowser Coc
Owner: ----
Status: Untriaged (was: Assigned)
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
[mac bug triage] 
Cc: a...@chromium.org
Labels: -Hotlist-CocoaBrowser -Coc
Owner: tommycli@chromium.org
This is Mac-only only because on Windows they aggressively squeeze down the glyphs in the font we use so that it fits. Barely.

This is something the Omnibox team should look at.

Sign in to add a comment