New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623490 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Webview process of preview page does not stop after killing manually when broswer is in fullscreen mode.

Reported by rk...@etouch.net, Jun 27 2016

Issue description

Chrome Version:53.0.2780.0 Revision 5453dc6abc2d7c797c7f9f16df8aed8e6358a217-refs/heads/master@{#402053} 
OS: Mac(10.11.4), Retina(10.11.4)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and give 'Print' command.
(2) Click on Fullscreen button from wrench, then open task manager.
(3) End Process of Plugin:Chrome PDF viewer and observe.

Webview process of preview page does not stop after step 2 and 3.

Webview process of preview page should be stop.

This is a regression issue, broken in 'M-53', below is bisect info:

Good Build: 53.0.2778.0
Bad Build: 53.0.2780.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/3c51f5db7293b1e6100d44e71497428cde6d520a..e39df25f0accb5148a6b9249bac1ec900556e904?pretty=fuller&n=100

Suspecting: r401796

Note: 1. Issue is not reproducible in non-full screen mode.
      2. Issue is not seen on Windows, Linux and Mac pro(10.10.5)
 
Actual_Behaviour.mov
2.4 MB Download
Expected_Behaviour.mov
1.9 MB Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ea3a9cd847d7478598d22804d04c32c156c14f4

commit 7ea3a9cd847d7478598d22804d04c32c156c14f4
Author: enne <enne@chromium.org>
Date: Mon Jun 27 21:38:43 2016

Revert of Turn on enable begin frame scheduling by default (patchset #11 id:200001 of https://codereview.chromium.org/1939253002/ )

Reason for revert:
Causes smoothness regressions, other bugs

BUG= 623174 , 623467 , 623490 

Original issue's description:
> Turn on enable begin frame scheduling by default
>
> This turns on --enable-begin-frame-scheduling[1] for all[2] platforms.
> This was already on for Android so should only be a real change
> for desktop / ChromeOS platforms.
>
> Lots of cleanup can follow from this like removing all commit vsync /
> authoritative vsync / CompositorVSyncManager things, but this is a
> smaller patch to suss out any performance regressions.
>
> [1] In this case, "begin frame scheduling" means browser->renderer
> begin frame ticks instead of sending vsync information and having
> a synthetic source on the renderer side.
>
> [2] MUS is not hooked up to begin frame scheduling yet, but
> mojo:mash_session in an "oxygen" build still works with this patch
> applied.  Blimp also doesn't use begin frame scheduling and will
> eventually just be transitioned to a synthetic begin frame source
> for its engine half.
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/f2d7f5e1891703ec4384ededd80f896816921204
> Cr-Commit-Position: refs/heads/master@{#401796}

TBR=boliu@chromium.org,piman@chromium.org,skyostil@chromium.org,sunnyps@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2100203002
Cr-Commit-Position: refs/heads/master@{#402294}

[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/android_webview/lib/main/aw_main_delegate.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/cc/base/switches.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/cc/base/switches.h
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/content/browser/android/content_startup_flags.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/7ea3a9cd847d7478598d22804d04c32c156c14f4/ui/compositor/compositor.cc

Labels: TE-Verified-M53 TE-Verified-53.0.2784.0
Tested this issue on Mac OS 10.11.5 using chrome latest canary M53-53.0.2784.0 by following steps mentioned in the original comment. Observed the print preview page is stopped as expected after ending the process from task manager. Since the issue is working as intended adding TE-Verified label.

Thanks!
PDFPlugin.mp4
1.5 MB View Download

Comment 4 by ajha@chromium.org, Jul 5 2016

enne@: Please let us know if there is further work to be done on this. If not please update the status of the bug as the revert is verified in C#3.

Comment 5 by enne@chromium.org, Jul 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment