Password settings on Android: redirect users to passwords.google.com |
|||||
Issue descriptionWhen viewing passwords in Chrome on Android is enabled, users who use sync without a custom passphrase should be redirected to passwords.google.com instead of the native settings.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13085d446efc3b8cd2c26338738c04a7516953a8 commit 13085d446efc3b8cd2c26338738c04a7516953a8 Author: dozsa <dozsa@google.com> Date: Thu Jul 21 12:04:15 2016 Redirect syncing users without sync passphrase to passwords.google.com This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature. BUG= 623488 Review-Url: https://codereview.chromium.org/2092723002 Cr-Commit-Position: refs/heads/master@{#406823} [modify] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [modify] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/android/java_sources.gni [add] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java [modify] https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8/chrome/browser/android/chrome_feature_list.cc
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c commit 0073a6f1f50b7347daa0b6b968f06c9bcf13e38c Author: tedchoc <tedchoc@chromium.org> Date: Thu Jul 21 17:24:44 2016 Revert of Redirect users without sync passphrase to passwords.google.com (patchset #50 id:980001 of https://codereview.chromium.org/2092723002/ ) Reason for revert: The tests are checking their expectations on the wrong thread. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35372/steps/chrome_public_test_apk/logs/stdio I 703.521s run_tests_on_device(0ca41989032f9f23) java.lang.AssertionError I 703.521s run_tests_on_device(0ca41989032f9f23) at org.chromium.base.ThreadUtils.assertOnUiThread(ThreadUtils.java:192) I 703.521s run_tests_on_device(0ca41989032f9f23) at org.chromium.chrome.browser.sync.ProfileSyncService.get(ProfileSyncService.java:104) I 703.521s run_tests_on_device(0ca41989032f9f23) at org.chromium.chrome.browser.preferences.PasswordViewingTypeTest.testUserRedirectSyncSettings(PasswordViewingTypeTest.java:133) I 703.521s run_tests_on_device(0ca41989032f9f23) at java.lang.reflect.Method.invokeNative(Native Method) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) I 703.521s run_tests_on_device(0ca41989032f9f23) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) I 703.521s run_tests_on_device(0ca41989032f9f23) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) Original issue's description: > Redirect syncing users without sync passphrase to passwords.google.com > > This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature. > > BUG= 623488 > > Committed: https://crrev.com/13085d446efc3b8cd2c26338738c04a7516953a8 > Cr-Commit-Position: refs/heads/master@{#406823} TBR=vabr@chromium.org,bauerb@chromium.org,dozsa@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 623488 Review-Url: https://codereview.chromium.org/2165333002 Cr-Commit-Position: refs/heads/master@{#406885} [modify] https://crrev.com/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [modify] https://crrev.com/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c/chrome/android/java_sources.gni [delete] https://crrev.com/a39093e45fdda514325b6ebfc27df2bac3f9f73e/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java [modify] https://crrev.com/0073a6f1f50b7347daa0b6b968f06c9bcf13e38c/chrome/browser/android/chrome_feature_list.cc
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86fa8831dcb7154bd60f77a532953517797d4f10 commit 86fa8831dcb7154bd60f77a532953517797d4f10 Author: dozsa <dozsa@google.com> Date: Mon Jul 25 10:07:18 2016 Reland: Redirect syncing users without sync passphrase to passwords.google.com This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature. This is a reland of https://codereview.chromium.org/2092723002/ BUG= 623488 Review-Url: https://codereview.chromium.org/2173713002 Cr-Commit-Position: refs/heads/master@{#407440} [modify] https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [modify] https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10/chrome/android/java_sources.gni [add] https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java
,
Feb 27 2017
The assigned owner "dozsa@google.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 27 2017
Assigning to vabr@ who currently owns the launch bug 617602. If you are interested in owning this, let vabr@ know.
,
May 2 2017
,
Jul 6 2017
Redirecting to p.g.c was removed from the design. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vabr@chromium.org
, Jun 27 2016Status: Started (was: Available)