New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623487 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Chromite Butler does not understand per-file OWNERS that refer to another OWNERS file

Project Member Reported by robpercival@chromium.org, Jun 27 2016

Issue description

Chromite Butler does not appear to understand per-file OWNERS directives that refer to another OWNERS file, e.g.

per-file foo.gypi=file://components/foo/OWNERS

It appears to interpret the owner of foo.gypi to be "file://components/foo/OWNERS", rather than looking at the contents of that file. For a concrete example, see https://codereview.chromium.org/2066553002/. The file "components/certificate_transparency.gypi" appears with a red box next to it labeled "No OWNER for this file in the reviewer list", yet one of the reviewers (Eran Messeri) is an owner of that file.
 
Assuming I haven't just failed to find it, any chance of getting Chromite Butler open-sourced (e.g. on GitHub)? Then bug reports wouldn't have to come through the Chromium bug tracker and other people could contribute fixes/improvements.
Status: Assigned (was: Untriaged)
Cc: sadrul@chromium.org
Owner: aval...@chromium.org
Status: Fixed (was: Assigned)
avallee@ implemented this for butler.

Sign in to add a comment