New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623459 link

Starred by 1 user
Status: Fixed
Owner:
█ fran...@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
bmeu...@chromium.org
verwa...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Inspector test debugger-eval-on-call-frame-inside-iframe fails with fixed IsNativeError()

Project Member Reported by fran...@chromium.org, Jun 27 2016 
After https://codereview.chromium.org/2090333002/ IaNativeError() is fixed, 
the inspector test case debugger-eval-on-call-frame-inside-iframe fails, because an error from a different context is not recognized as such and debug output is slightly different.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c651733e1fcb9319c74c16b03c612aa8eb0baa8e

commit c651733e1fcb9319c74c16b03c612aa8eb0baa8e
Author: franzih <franzih@chromium.org>
Date: Mon Jun 27 07:09:16 2016

Skipping test that needs to be rebaselined after https://crrev.com/2090333002 rolls.

Inspector test case need manual rebaseline

R=machenbach@chromium.org
BUG= chromium:623459 
Log=n

Review-Url: https://codereview.chromium.org/2100043002
Cr-Commit-Position: refs/heads/master@{#402128}

[modify] https://crrev.com/c651733e1fcb9319c74c16b03c612aa8eb0baa8e/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e6ad562c4556be1d64176ce5a748a2eb72efe0

commit 94e6ad562c4556be1d64176ce5a748a2eb72efe0
Author: franzih <franzih@chromium.org>
Date: Wed Jun 29 13:58:08 2016

Mark inspector test for rebaseline.

V8 with commit https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b has landed in Canary, so mark inspector test case debugger-eval-on-call-frame-inside-iframe for automatic rebaseline.

R=machenbach@chromium.org
BUG= chromium:623459 
Log=n

Review-Url: https://codereview.chromium.org/2106103002
Cr-Commit-Position: refs/heads/master@{#402794}

[modify] https://crrev.com/94e6ad562c4556be1d64176ce5a748a2eb72efe0/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by fran...@chromium.org, Jun 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment