win compile flake: printing_test_support.print_mock_render_thread Cannot open include file: 'services/shell/public/interfaces/interface_provider.mojom.h' |
||
Issue descriptionVersion: Win x64 From a waterfall build https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1934 in the revision range, only html and .py files are changing. Error is [4456/32854] CXX obj\components\printing\test\printing_test_support.print_mock_render_thread.obj FAILED: obj/components/printing/test/printing_test_support.print_mock_render_thread.obj ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\components\printing\test\printing_test_support.print_mock_render_thread.obj.rsp /c ..\..\components\printing\test\print_mock_render_thread.cc /Foobj\components\printing\test\printing_test_support.print_mock_render_thread.obj /Fdobj\components\printing_test_support.cc.pdb c:\b\build\slave\win_x64\build\src\content\public\test\mock_render_thread.h(19): fatalerror C1083: Cannot open include file: 'services/shell/public/interfaces/interface_provider.mojom.h': No such file or directory Can public/test/mock_render_thread.h use a forward-declare maybe? Or perhaps we are just waiting for this builder to switch to gn :/
,
Jun 27 2016
flaked again in https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1937 but https://build.chromium.org/p/chromium/builders/Win%20x64?numbuilds=200 doesn't have other compile failures attributed to this. components/printing.gypi has been quiet. But mock_render_thread.h picked up the header dependency in r401130 -- about a ~week ago. Issue 605318 is the bug for converting all the win bots over to GN - it looks like things are close. GN handles gyp's "hard dependency" thing automatically, which I think is how this would be fixed otherwise. I don't know how to easily tell from the builder output whether it's definitely using gyp or gn.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f96c32e6b2e1e7c96de4187435849c847a2b442 commit 8f96c32e6b2e1e7c96de4187435849c847a2b442 Author: amistry <amistry@chromium.org> Date: Mon Jun 27 07:58:38 2016 Depend on content test support from printing test support library. BUG= 623452 Review-Url: https://codereview.chromium.org/2093373003 Cr-Commit-Position: refs/heads/master@{#402134} [modify] https://crrev.com/8f96c32e6b2e1e7c96de4187435849c847a2b442/components/printing.gypi
,
Jun 27 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by amistry@chromium.org
, Jun 27 2016Owner: amistry@chromium.org
Status: Started (was: Available)