New issue
Advanced search Search tips

Issue 623438 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Shelf items have incorrect layout when switching from left-aligned shelf to right-aligned shelf

Project Member Reported by tdander...@chromium.org, Jun 27 2016

Issue description

Version: 53 ToT
OS: Chrome OS
Cause of regression (confirmed with bisect): https://crrev.com/20e7d3f385060e0c2de2a86d5dcf81c4c0ca8c8f

Note: Marked as Proj-MaterialDesign-CrOS for tracking purposes, since the offending CL was a material design change. However, this regression is only seen when Ash material design is *not* enabled.

Steps to reproduce:
1. In an Ash desktop, switch the shelf orientation from bottom to left.
2. Switch the shelf orientation from left to right.

What happens:
The items in the system tray area (system tray, notifications button) are 6px from the right edge of the screen (including the 3px black bar containing the activity indicators). Clicking on one of these items will cause it to re-layout to be 9px from the right edge of the screen.

What should happen instead:
The items in the system tray area (system tray, notifications button) should be 9px from the right edge of the screen. Clicking on these items should not cause their layout to change.

Note: the bug also reproduces if you instead switch from bottom->right->left.
 
Correction: in #0 I mean 'dp' instead of 'px'.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeee71c610e8e6548b94d3abb180fd53d16a487d

commit eeee71c610e8e6548b94d3abb180fd53d16a487d
Author: yiyix <yiyix@chromium.org>
Date: Thu Jun 30 17:46:17 2016

Fix shelf layout when switching from left-aligned shelf to right-aligned shelf

Fix the issue that when shelf is switched from left-aligned shelf to
right-aligned shelf, the spacing between the edge of the screen to tray
items are not changed.

TEST=Manuel
- change shelf location left to right or right to left.
- change shelf location bottom to right or bottom to left.
- initialize shelf locating on left or right.

BUG= 623438 

Review-Url: https://codereview.chromium.org/2103113003
Cr-Commit-Position: refs/heads/master@{#403215}

[modify] https://crrev.com/eeee71c610e8e6548b94d3abb180fd53d16a487d/ash/common/system/status_area_widget_delegate.cc

Comment 4 by yiyix@chromium.org, Jun 30 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment