New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Upstream tests from LayoutTests/web-animations-api to web platform tests

Project Member Reported by suzyh@chromium.org, Jun 27 2016

Issue description

All tests in LayoutTests/web-animations-api should be either upstreamed to the W3C web-platform-tests test suite or moved to LayoutTests/animations.


Edit (17 Oct 2016): Design doc: https://docs.google.com/document/d/12-xWfWY1RpT06JJk4dBFGK-GSr28j1hiQBrVflyZRdw/edit
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b109e5c24f8e5b9dd4d1375c1309082a4abec52

commit 2b109e5c24f8e5b9dd4d1375c1309082a4abec52
Author: suzyh <suzyh@chromium.org>
Date: Thu Jun 30 06:41:37 2016

Move web-animations-api tests not being upstreamed

In preparation for upstreaming the tests in LayoutTests/web-animations-api to
the W3C web-platform-tests test suite, this patch moves tests that will not be
upstreamed to LayoutTests/animations. One obsolete test
(timeline-play-animation.html) is also deleted (document.timeline.play
is no longer in the spec).

BUG= 623437 

Review-Url: https://codereview.chromium.org/2093423002
Cr-Commit-Position: refs/heads/master@{#403103}

[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-assorted-lengths.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-backgroundPosition.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-backgroundSize.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-borderImageWidth.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-borderRadius.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-borderWidth.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-boxShadow.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-fontSize.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-fontWeight.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-minHeight.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-opacity.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-perspective.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-shapeMargin.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-strokeDasharray.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-textIndent.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-to-color-change.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-to-inherited-change.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-to-style-change.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-transform.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-translate.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/animations-responsive-verticalAlign.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/change-in-animation-frame-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/change-in-animation-frame.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/deprecated-hyphen-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/deprecated-hyphen.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-float-crash-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-float-crash.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-font-style-crash-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-font-style-crash.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-no-style-recalc.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-position-crash-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/element-animate-position-crash.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/finish-event-after-gc.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/font-builder-crash-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/font-builder-crash.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/get-css-players.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/option-element-crash-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/option-element-crash.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/resource-loading-expected.txt
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/resource-loading.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/start-time-grouping.html
[rename] https://crrev.com/2b109e5c24f8e5b9dd4d1375c1309082a4abec52/third_party/WebKit/LayoutTests/animations/transitions-replay.html
[delete] https://crrev.com/6f17c653312de642e47c6c1f05415a2128bcfedd/third_party/WebKit/LayoutTests/web-animations-api/timeline-play-animation.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/565db0d042d2cbc46b04094caf773f210d4d38b0

commit 565db0d042d2cbc46b04094caf773f210d4d38b0
Author: nainar <nainar@chromium.org>
Date: Tue Jul 12 02:29:20 2016

Delete test that is already being tested in w3c test suite

Delete the test as already being tested here:
https://github.com/w3c/web-platform-tests/blob/master/web-animations/interfaces/Animatable/animate.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2143483003
Cr-Commit-Position: refs/heads/master@{#404768}

[delete] https://crrev.com/a1272f22cff24d0ffe945665dbc4338d39107466/third_party/WebKit/LayoutTests/web-animations-api/animation-id.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb8e41485ecfdff19c0bae2e9332331d700be9a9

commit eb8e41485ecfdff19c0bae2e9332331d700be9a9
Author: samli <samli@chromium.org>
Date: Tue Jul 12 02:59:36 2016

Animations: Fix element.animate() null effect test

BUG= 623437 

Review-Url: https://codereview.chromium.org/2140913002
Cr-Commit-Position: refs/heads/master@{#404771}

[modify] https://crrev.com/eb8e41485ecfdff19c0bae2e9332331d700be9a9/third_party/WebKit/LayoutTests/web-animations-api/element-animate-null-effect.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21d3644aee2172836ca3297beeeb5de3b8de82b7

commit 21d3644aee2172836ca3297beeeb5de3b8de82b7
Author: samli <samli@chromium.org>
Date: Tue Jul 12 04:08:45 2016

Animations: Remove player-play-with-negative-current-time.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2144463002
Cr-Commit-Position: refs/heads/master@{#404779}

[delete] https://crrev.com/4ac11035813e3829bb7eef3a022807b8ffc0b758/third_party/WebKit/LayoutTests/web-animations-api/player-play-with-negative-current-time.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e564da3ba2ceb2dd78565154e7fbb48f92a573b

commit 1e564da3ba2ceb2dd78565154e7fbb48f92a573b
Author: nainar <nainar@chromium.org>
Date: Tue Jul 12 04:11:14 2016

Delete test player-cancel-invalidates-style.html

Delete test player-cancel-invalidates-style.html as it is already tested
in https://github.com/w3c/web-platform-tests/blob/master/web-animations/interfaces/Animation/cancel.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2138293003
Cr-Commit-Position: refs/heads/master@{#404780}

[delete] https://crrev.com/21d3644aee2172836ca3297beeeb5de3b8de82b7/third_party/WebKit/LayoutTests/web-animations-api/player-cancel-invalidates-style.html

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a2a0b2dbcc139d344271994cbdfc1d7f3726746

commit 0a2a0b2dbcc139d344271994cbdfc1d7f3726746
Author: samli <samli@chromium.org>
Date: Tue Jul 12 04:13:10 2016

Animations: Remove player.html test

Test is broken (see expectations), used outdated APIs (eg. timelag), is duplicated by W3C tests and basic IDL checks.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2139163002
Cr-Commit-Position: refs/heads/master@{#404782}

[delete] https://crrev.com/4de054ddd802a66e912b5d1e29666d58413148ff/third_party/WebKit/LayoutTests/web-animations-api/player-expected.txt
[delete] https://crrev.com/4de054ddd802a66e912b5d1e29666d58413148ff/third_party/WebKit/LayoutTests/web-animations-api/player.html

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21808e254d52527520140a488003ac32d56a9a72

commit 21808e254d52527520140a488003ac32d56a9a72
Author: nainar <nainar@chromium.org>
Date: Tue Jul 12 05:35:52 2016

Add the relevant information to the test and use testcommon.js

BUG= 623437 

Review-Url: https://codereview.chromium.org/2139113002
Cr-Commit-Position: refs/heads/master@{#404785}

[modify] https://crrev.com/21808e254d52527520140a488003ac32d56a9a72/third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ff562149d851eb2b539f25676b15b3dfc1c139

commit 65ff562149d851eb2b539f25676b15b3dfc1c139
Author: andymutton <andymutton@chromium.org>
Date: Tue Jul 12 06:11:31 2016

Delete player-finished-promise.html

Tests in this file are all covered by existing w3c web platform tests in
https://github.com/w3c/web-platform-tests/blob/master/web-animations/interfaces/Animation/finished.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2140013002
Cr-Commit-Position: refs/heads/master@{#404787}

[delete] https://crrev.com/f8f67bb5d779485ad13daa1ee42268a2e90642b7/third_party/WebKit/LayoutTests/web-animations-api/player-finished-promise.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23acb16dc5e79086933eb124485433d4ad0d234e

commit 23acb16dc5e79086933eb124485433d4ad0d234e
Author: sashab <sashab@chromium.org>
Date: Tue Jul 12 06:12:02 2016

Removed non-animatable-property.html test to match W3C

Removed web-animations-api/non-animatable-property.html test since it
is a duplicate of
interfaces/KeyframeEffect/processing-a-keyframes-argument.html. Part of
the web animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2141713003
Cr-Commit-Position: refs/heads/master@{#404788}

[delete] https://crrev.com/65ff562149d851eb2b539f25676b15b3dfc1c139/third_party/WebKit/LayoutTests/web-animations-api/non-animatable-property.html

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00fe80aa4a431a9aff84b52ec17d9de672cd87c5

commit 00fe80aa4a431a9aff84b52ec17d9de672cd87c5
Author: sashab <sashab@chromium.org>
Date: Tue Jul 12 07:27:27 2016

Removed web-animations-api/deferred-updates.html test

Removed web-animations-api/deferred-updates.html test, since its
not adding testing coverage/value.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2141703004
Cr-Commit-Position: refs/heads/master@{#404793}

[delete] https://crrev.com/28e7a0cc33dafc8719c4b9c740d79a47ff90f067/third_party/WebKit/LayoutTests/web-animations-api/deferred-updates.html

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e84dff8a9a31764ed276346d78d347458ba125

commit 13e84dff8a9a31764ed276346d78d347458ba125
Author: meade <meade@chromium.org>
Date: Tue Jul 12 07:42:44 2016

Rewrite animationtimeline-consistent into animation-playbackRate

This tests that the animation's currentTime is constant when its
playbackRate is 0.

This test is intended for upstreaming in
interfaces/Animation/playbackRate.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2137403002
Cr-Commit-Position: refs/heads/master@{#404795}

[add] https://crrev.com/13e84dff8a9a31764ed276346d78d347458ba125/third_party/WebKit/LayoutTests/web-animations-api/animation-playbackRate.html
[delete] https://crrev.com/ddff3868a676e8aa57ec7f93d19019597250ab76/third_party/WebKit/LayoutTests/web-animations-api/animationtimeline-consistent.html

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3035c93dea581354140f512b4357c795c7ca310b

commit 3035c93dea581354140f512b4357c795c7ca310b
Author: shans <shans@chromium.org>
Date: Tue Jul 12 08:06:50 2016

Fix test expectations to match specification (I think)

BUG= 623437 

Review-Url: https://codereview.chromium.org/2145503002
Cr-Commit-Position: refs/heads/master@{#404798}

[modify] https://crrev.com/3035c93dea581354140f512b4357c795c7ca310b/third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframe-properties.html

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1451b85419bd8f31d57ac65b2c8aecbe514bd1ac

commit 1451b85419bd8f31d57ac65b2c8aecbe514bd1ac
Author: meade <meade@chromium.org>
Date: Tue Jul 12 09:49:28 2016

Delete obsolete test for AnimationTimeline.

The AnimationTimeline spec no longer has a playbackRate
attribute so there's no point in testing it.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2145473002
Cr-Commit-Position: refs/heads/master@{#404800}

[delete] https://crrev.com/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543/third_party/WebKit/LayoutTests/web-animations-api/timeline-set-current-time-playback-rate.html

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94356d17d5aec284672b75ad0ccbbba09d154567

commit 94356d17d5aec284672b75ad0ccbbba09d154567
Author: shans <shans@chromium.org>
Date: Tue Jul 12 23:44:29 2016

Modified iterable keyframes test to use KeyframeEffect constructor and
getFrames directly. Note that this test will not pass in Chrome and is
intended for upload to web-platform-tests.

Added original test to animations directory to maintain coverage.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2142733002
Cr-Commit-Position: refs/heads/master@{#404861}

[rename] https://crrev.com/94356d17d5aec284672b75ad0ccbbba09d154567/third_party/WebKit/LayoutTests/animations/element-animate-iterable-keyframes.html
[add] https://crrev.com/94356d17d5aec284672b75ad0ccbbba09d154567/third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes-expected.txt
[add] https://crrev.com/94356d17d5aec284672b75ad0ccbbba09d154567/third_party/WebKit/LayoutTests/web-animations-api/keyframe-effect-iterable-keyframes.html

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 13 2016

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee

commit 3eda0025374cfc23d3e9af70f945f1a7b3ac6fee
Author: sashab <sashab@chromium.org>
Date: Wed Jul 13 03:55:17 2016

Cleaned up animation-state-changes.html test to meet W3C standards

Cleaned up animation-state-changes.html test to meet W3C standards. Part
of web animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2142763002
Cr-Commit-Position: refs/heads/master@{#404989}

[delete] https://crrev.com/4e06b89862297eef8d4600930292cbae23695244/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes.html
[add] https://crrev.com/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee/third_party/WebKit/LayoutTests/web-animations-api/playState-changes.html

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c6be5c7b8561fb13df05f64f404f13e4e8ba68

commit 26c6be5c7b8561fb13df05f64f404f13e4e8ba68
Author: samli <samli@chromium.org>
Date: Wed Jul 13 04:56:20 2016

Animations: Delete infinite-end-time.html test

This test is duplicated across the W3C web animations tests.
https://github.com/w3c/web-platform-tests/tree/master/web-animations/interfaces/Animation

BUG= 623437 

Review-Url: https://codereview.chromium.org/2140933002
Cr-Commit-Position: refs/heads/master@{#405031}

[delete] https://crrev.com/876a4bf3c87650e733c34a494f7f1d9ef57a391d/third_party/WebKit/LayoutTests/web-animations-api/infinite-end-time.html

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758

commit f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758
Author: meade <meade@chromium.org>
Date: Wed Jul 13 05:58:18 2016

Add meta, help and title to web-animations-api/timeline-time.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2145843002
Cr-Commit-Position: refs/heads/master@{#405050}

[modify] https://crrev.com/f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758/third_party/WebKit/LayoutTests/web-animations-api/timeline-time.html

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5

commit 4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5
Author: suzyh <suzyh@chromium.org>
Date: Wed Jul 13 06:24:28 2016

Replace undefined assert_undefined function.

assert_undefined(v) was a convenience function for assert_equals(v, null) that
was lost when merging player-unresolved-times.html with the W3C startTime.html
test file in http://crrev.com/2141853002

BUG= 623437 

Review-Url: https://codereview.chromium.org/2147643003
Cr-Commit-Position: refs/heads/master@{#405055}

[modify] https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5/third_party/WebKit/LayoutTests/web-animations-api/startTime-expected.txt
[modify] https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5/third_party/WebKit/LayoutTests/web-animations-api/startTime.html

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a76d61ea07af587d99e385e67767f89d55ec19d

commit 0a76d61ea07af587d99e385e67767f89d55ec19d
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:47:32 2016

Prepare animation-cancel-event.html for upstreaming

BUG= 623437 

Review-Url: https://codereview.chromium.org/2137333002
Cr-Commit-Position: refs/heads/master@{#405090}

[rename] https://crrev.com/0a76d61ea07af587d99e385e67767f89d55ec19d/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8e6f01017974da96df4f479e7fdf6513088d7a

commit bb8e6f01017974da96df4f479e7fdf6513088d7a
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:51:38 2016

Remove w3c/same-offset-keyframes

Redundant with animation-model/keyframe-effects/the-effect-value-of-a-keyframe-effect.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2139683003
Cr-Commit-Position: refs/heads/master@{#405094}

[delete] https://crrev.com/87a189f1566ce8cf72b77dac8cb54ec6bc4ab27c/third_party/WebKit/LayoutTests/web-animations-api/w3c/same-offset-keyframes.html

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d

commit 5f8f3e2454dd9950db9f11e4dc79ddb0590c876d
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:52:32 2016

Prepare animation-finish-event-cancelled for upstreaming

BUG= 623437 

Review-Url: https://codereview.chromium.org/2141823002
Cr-Commit-Position: refs/heads/master@{#405095}

[rename] https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d/third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a794422b73ab4ea7276f42260caeb97dc574eff8

commit a794422b73ab4ea7276f42260caeb97dc574eff8
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:53:06 2016

Remove out-of-order-keyframes

Merging with interfaces/KeyframeEffect/processing-a-keyframes-argument.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2134253004
Cr-Commit-Position: refs/heads/master@{#405096}

[delete] https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d/third_party/WebKit/LayoutTests/web-animations-api/w3c/out-of-order-keyframes.html

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad40c1b8c4d5ce1bea5cd7d9e892e19ecd75a2d0

commit ad40c1b8c4d5ce1bea5cd7d9e892e19ecd75a2d0
Author: samli <samli@chromium.org>
Date: Wed Jul 13 02:45:56 2016

Animations: Fix quirky-keyframes.html test

Add a test to be upstreamed to a W3C test of the same name.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2135333003
Cr-Commit-Position: refs/heads/master@{#404927}

[delete] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/web-animations-api/quirky-keyframes.html
[add] https://crrev.com/ad40c1b8c4d5ce1bea5cd7d9e892e19ecd75a2d0/third_party/WebKit/LayoutTests/web-animations-api/the-effect-value-of-a-keyframe-effect.html

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee

commit 3eda0025374cfc23d3e9af70f945f1a7b3ac6fee
Author: sashab <sashab@chromium.org>
Date: Wed Jul 13 03:55:17 2016

Cleaned up animation-state-changes.html test to meet W3C standards

Cleaned up animation-state-changes.html test to meet W3C standards. Part
of web animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2142763002
Cr-Commit-Position: refs/heads/master@{#404989}

[delete] https://crrev.com/4e06b89862297eef8d4600930292cbae23695244/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes.html
[add] https://crrev.com/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee/third_party/WebKit/LayoutTests/web-animations-api/playState-changes.html

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c6be5c7b8561fb13df05f64f404f13e4e8ba68

commit 26c6be5c7b8561fb13df05f64f404f13e4e8ba68
Author: samli <samli@chromium.org>
Date: Wed Jul 13 04:56:20 2016

Animations: Delete infinite-end-time.html test

This test is duplicated across the W3C web animations tests.
https://github.com/w3c/web-platform-tests/tree/master/web-animations/interfaces/Animation

BUG= 623437 

Review-Url: https://codereview.chromium.org/2140933002
Cr-Commit-Position: refs/heads/master@{#405031}

[delete] https://crrev.com/876a4bf3c87650e733c34a494f7f1d9ef57a391d/third_party/WebKit/LayoutTests/web-animations-api/infinite-end-time.html

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758

commit f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758
Author: meade <meade@chromium.org>
Date: Wed Jul 13 05:58:18 2016

Add meta, help and title to web-animations-api/timeline-time.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2145843002
Cr-Commit-Position: refs/heads/master@{#405050}

[modify] https://crrev.com/f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758/third_party/WebKit/LayoutTests/web-animations-api/timeline-time.html

Project Member

Comment 41 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5

commit 4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5
Author: suzyh <suzyh@chromium.org>
Date: Wed Jul 13 06:24:28 2016

Replace undefined assert_undefined function.

assert_undefined(v) was a convenience function for assert_equals(v, null) that
was lost when merging player-unresolved-times.html with the W3C startTime.html
test file in http://crrev.com/2141853002

BUG= 623437 

Review-Url: https://codereview.chromium.org/2147643003
Cr-Commit-Position: refs/heads/master@{#405055}

[modify] https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5/third_party/WebKit/LayoutTests/web-animations-api/startTime-expected.txt
[modify] https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5/third_party/WebKit/LayoutTests/web-animations-api/startTime.html

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a76d61ea07af587d99e385e67767f89d55ec19d

commit 0a76d61ea07af587d99e385e67767f89d55ec19d
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:47:32 2016

Prepare animation-cancel-event.html for upstreaming

BUG= 623437 

Review-Url: https://codereview.chromium.org/2137333002
Cr-Commit-Position: refs/heads/master@{#405090}

[rename] https://crrev.com/0a76d61ea07af587d99e385e67767f89d55ec19d/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-event.html

Project Member

Comment 47 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8e6f01017974da96df4f479e7fdf6513088d7a

commit bb8e6f01017974da96df4f479e7fdf6513088d7a
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:51:38 2016

Remove w3c/same-offset-keyframes

Redundant with animation-model/keyframe-effects/the-effect-value-of-a-keyframe-effect.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2139683003
Cr-Commit-Position: refs/heads/master@{#405094}

[delete] https://crrev.com/87a189f1566ce8cf72b77dac8cb54ec6bc4ab27c/third_party/WebKit/LayoutTests/web-animations-api/w3c/same-offset-keyframes.html

Project Member

Comment 48 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d

commit 5f8f3e2454dd9950db9f11e4dc79ddb0590c876d
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:52:32 2016

Prepare animation-finish-event-cancelled for upstreaming

BUG= 623437 

Review-Url: https://codereview.chromium.org/2141823002
Cr-Commit-Position: refs/heads/master@{#405095}

[rename] https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d/third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html

Project Member

Comment 49 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a794422b73ab4ea7276f42260caeb97dc574eff8

commit a794422b73ab4ea7276f42260caeb97dc574eff8
Author: dstockwell <dstockwell@chromium.org>
Date: Wed Jul 13 08:53:06 2016

Remove out-of-order-keyframes

Merging with interfaces/KeyframeEffect/processing-a-keyframes-argument.html

BUG= 623437 

Review-Url: https://codereview.chromium.org/2134253004
Cr-Commit-Position: refs/heads/master@{#405096}

[delete] https://crrev.com/5f8f3e2454dd9950db9f11e4dc79ddb0590c876d/third_party/WebKit/LayoutTests/web-animations-api/w3c/out-of-order-keyframes.html

Comment 50 by suzyh@chromium.org, Jul 13 2016

Labels: -merge-merged-2795
Looks like bugdroid got overly enthusiastic there, and added a spurious merge-merged label as well as a second copy of several commit messages.
Project Member

Comment 52 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89e8e2dd7b68b051fc18f04dc8106aea3720b64

commit b89e8e2dd7b68b051fc18f04dc8106aea3720b64
Author: sashab <sashab@chromium.org>
Date: Thu Jul 14 00:54:37 2016

Cleaned up simple-keyframes.html test

Cleaned up simple-keyframes.html test to better match W3C standards.
Part of web animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2138333002
Cr-Commit-Position: refs/heads/master@{#405373}

[modify] https://crrev.com/b89e8e2dd7b68b051fc18f04dc8106aea3720b64/third_party/WebKit/LayoutTests/web-animations-api/w3c/simple-keyframes.html

Project Member

Comment 53 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8a910760e0c33dc93b4751e330b729936a1df5c

commit d8a910760e0c33dc93b4751e330b729936a1df5c
Author: suzyh <suzyh@chromium.org>
Date: Thu Jul 14 01:22:13 2016

Rewrite test in terms of promise rejection

This patch rewrites animation-finish-event-cancelled.html to listen for
rejection of the animation's finished promise instead of using a combination
of onfinish and assertions about code being unreached. This makes the test
easier to read and brings it more in line with the style of tests in the
web-platform-tests suite.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2145263002
Cr-Commit-Position: refs/heads/master@{#405384}

[modify] https://crrev.com/d8a910760e0c33dc93b4751e330b729936a1df5c/third_party/WebKit/LayoutTests/web-animations-api/animation-finish-event-cancelled.html

Project Member

Comment 54 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71712a3b5094ad75cfaac6b25067668eb5962402

commit 71712a3b5094ad75cfaac6b25067668eb5962402
Author: sashab <sashab@chromium.org>
Date: Thu Jul 14 01:35:18 2016

Remove eased-keyframes-non-animatable.html test

Removed eased-keyframes-non-animatable.html test since it is a duplicate
of animation-model/animation-types/discrete-animation.html. Part of web
animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2136323003
Cr-Commit-Position: refs/heads/master@{#405390}

[delete] https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698/third_party/WebKit/LayoutTests/web-animations-api/eased-keyframes-non-animatable.html

Project Member

Comment 55 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6191a6d0e303a084a33c94a95ed6ba3d058bc481

commit 6191a6d0e303a084a33c94a95ed6ba3d058bc481
Author: suzyh <suzyh@chromium.org>
Date: Thu Jul 14 01:36:48 2016

Style cleanup in animation layout test.

Minor style cleanup: replacing "promise.then(null, f)" with
"promise.catch(f)" in animation-cancel-ready-finished-ordering.html.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2149783004
Cr-Commit-Position: refs/heads/master@{#405392}

[modify] https://crrev.com/6191a6d0e303a084a33c94a95ed6ba3d058bc481/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html

Project Member

Comment 56 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1adf0ee89ff0fc220845bcef943e464fa114f5b3

commit 1adf0ee89ff0fc220845bcef943e464fa114f5b3
Author: sashab <sashab@chromium.org>
Date: Thu Jul 14 02:41:00 2016

Clean up player-finish-*.html tests to match W3C

Clean up web-animations-api/player-finish-*.html tests to match W3C
standards. Part of web animations test burndown.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2140023002
Cr-Commit-Position: refs/heads/master@{#405409}

[add] https://crrev.com/1adf0ee89ff0fc220845bcef943e464fa114f5b3/third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-event-expected.txt
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-event.html
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-repeats-expected.txt
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-repeats.html
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-sample-only-expected.txt
[delete] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/third_party/WebKit/LayoutTests/web-animations-api/player-finish-sample-only.html

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f56f02d3e666e2945bd2d841d57714e6f2c6f15b

commit f56f02d3e666e2945bd2d841d57714e6f2c6f15b
Author: suzyh <suzyh@chromium.org>
Date: Thu Jul 14 02:42:29 2016

Prepare time-consistent-across-frames for upstreaming

BUG= 623437 

Review-Url: https://codereview.chromium.org/2149053002
Cr-Commit-Position: refs/heads/master@{#405411}

[modify] https://crrev.com/f56f02d3e666e2945bd2d841d57714e6f2c6f15b/third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html

Project Member

Comment 60 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83dd2ca071ffd12a513320f5cd0ef24e005a77e3

commit 83dd2ca071ffd12a513320f5cd0ef24e005a77e3
Author: andymutton <andymutton@chromium.org>
Date: Thu Jul 14 02:50:10 2016

Add metadata and improve descriptions for null keyframe offset test.

BUG= 623437 

Review-Url: https://codereview.chromium.org/2137293003
Cr-Commit-Position: refs/heads/master@{#405421}

[modify] https://crrev.com/83dd2ca071ffd12a513320f5cd0ef24e005a77e3/third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html

Comment 62 by suzyh@chromium.org, Jul 20 2016

alancutter and I have taken the contents of LayoutTests/web-animations-api after the burndown on Jul 12 (which generated most of the above CLs) and have done the final steps converting them to patches against the web-platform-tests repository (my fork: https://github.com/suzyh/web-platform-tests/tree/blink-upstreaming-master/web-animations). Alan has submitted the first pull request for Brian's review (https://github.com/w3c/web-platform-tests/pull/3314). Once that's been lgtm'd we'll progressively submit the others.

Comment 63 by suzyh@chromium.org, Aug 22 2016

Status update: 3 pull requests have been merged, 3 retracted, 1 in active review, 17 more open.

Comment 64 by suzyh@chromium.org, Sep 22 2016

Status update: 4 merged, 4 closed, 16 open. Bandwidth on both sides of the review process is extremely limited.

Comment 65 by suzyh@chromium.org, Oct 10 2016

Labels: Objective

Comment 67 by suzyh@chromium.org, Oct 17 2016

Description: Show this description

Comment 68 by suzyh@chromium.org, Oct 26 2016

Status update: 5 merged, 4 retracted or closed in favour of other PRs, 15 open.

Comment 69 by suzyh@chromium.org, Nov 23 2016

Cc: suzyh@chromium.org
Labels: -Update-Monthly Update-Quarterly
Owner: ----
Status: Available (was: Started)
No recent changes. I'm dropping the update frequency to Quarterly, and unassigning myself, since I'm not actively working on this and it is not urgent.
Labels: -Objective
This is no longer an OKR.
Status update: 12 merged, 5 retracted/closed, 7 open

Comment 72 by suzyh@chromium.org, Mar 29 2017

Labels: Objective
Re-adding the Objective label since its purpose is intended to be descriptive of the type of work/bug this is, not whether it is a current OKR.

Comment 73 by suzyh@chromium.org, May 25 2017

Cc: -suzyh@chromium.org
Owner: suzyh@chromium.org
All of the pull requests have now been merged or closed. I'll take this to do the final cleanup of duplicate test coverage.
For some reason bugdroid hasn't updated this bug with https://codereview.chromium.org/2910883002:

Clean up duplicate tests in web-animations-api

Most of the tests in the LayoutTests/web-animations-api directory have
been upstreamed to the Web Platform Tests and are now redundant with
tests in external/wpt/web-animations. This patch deletes the redundant
test files.

Test files that were added after the push to prepare the tests for
upstreaming, or that were not upstreamed due to a need for further
changes, have been moved to LayoutTests/animations to simplify the test
directory structure.

Some additional references to no-longer-existing tests in the
web-animations-api directory have been removed from FlagExpectations and
SmokeTests. The virtual/stable/web-animations-api tests have not been
touched.

BUG= 623437 ,591099

Review-Url: https://codereview.chromium.org/2910883002
Cr-Commit-Position: refs/heads/master@{#477224}
Committed: https://chromium.googlesource.com/chromium/src/+/c8516e444e4348c99158fa53ea43f73c8a799d29

Status: Fixed (was: Available)

Sign in to add a comment