New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623436 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Hide Android's Settings app from the Chrome OS notification setting UI.

Project Member Reported by hirono@chromium.org, Jun 27 2016

Issue description

Version: ToT
OS: Chrome OS

We don't have Android Settings in launcher.
We also need to hide it in notification setting.

 

Comment 1 by hirono@chromium.org, Jun 27 2016

Cc: yoshiki@chromium.org

Comment 2 by hirono@chromium.org, Jun 27 2016

Summary: Hide Android's Settings app from the Chrome OS notification setting UI. (was: Hide Android Settings in notification setting.)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f918658ca2a84d0124aaf98bd69e3755d9c61b2

commit 1f918658ca2a84d0124aaf98bd69e3755d9c61b2
Author: hirono <hirono@chromium.org>
Date: Tue Jul 05 09:54:54 2016

Filter out Android system packages from Chrome OS notification settings.

In Android Settings application, there are no UI to disable
notifications for system packages.
The CL filter out system packages from Chrome OS notification settings
UI as well.

BUG= 623436 
TEST=manually tested on minnie

Review-Url: https://codereview.chromium.org/2102433002
Cr-Commit-Position: refs/heads/master@{#403761}

[modify] https://crrev.com/1f918658ca2a84d0124aaf98bd69e3755d9c61b2/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
[modify] https://crrev.com/1f918658ca2a84d0124aaf98bd69e3755d9c61b2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/1f918658ca2a84d0124aaf98bd69e3755d9c61b2/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/1f918658ca2a84d0124aaf98bd69e3755d9c61b2/components/arc/common/app.mojom

Cc: hirono@chromium.org
 Issue 625908  has been merged into this issue.
Labels: Merge-Request-53
Status: Fixed (was: Started)

Comment 6 by dimu@google.com, Jul 6 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f01a17a700421b28f488f84dabf2e69f163a57

commit 02f01a17a700421b28f488f84dabf2e69f163a57
Author: Daichi Hirono <hirono@chromium.org>
Date: Wed Jul 06 09:36:09 2016

Filter out Android system packages from Chrome OS notification settings.

In Android Settings application, there are no UI to disable
notifications for system packages.
The CL filter out system packages from Chrome OS notification settings
UI as well.

BUG= 623436 
TEST=manually tested on minnie

Review-Url: https://codereview.chromium.org/2102433002
Cr-Commit-Position: refs/heads/master@{#403761}
(cherry picked from commit 1f918658ca2a84d0124aaf98bd69e3755d9c61b2)

Review URL: https://codereview.chromium.org/2119393003 .

Cr-Commit-Position: refs/branch-heads/2785@{#21}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/02f01a17a700421b28f488f84dabf2e69f163a57/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
[modify] https://crrev.com/02f01a17a700421b28f488f84dabf2e69f163a57/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/02f01a17a700421b28f488f84dabf2e69f163a57/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/02f01a17a700421b28f488f84dabf2e69f163a57/components/arc/common/app.mojom

Comment 8 by osh...@chromium.org, Jul 11 2016

Status: Started (was: Fixed)

Comment 9 by osh...@chromium.org, Jul 11 2016

Status: Fixed (was: Started)
oops, sorry my mistake.
Status: Verified (was: Fixed)
Verified on M53 Beta 8530.49.0, 53.0.2785.55

Sign in to add a comment