New issue
Advanced search Search tips

Issue 623421 link

Starred by 2 users
Status: Fixed
Owner:
tapted@chromium.org
Closed: Dec 2016
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

MacViews: WidgetTest.Transparency_DesktopWidgetTranslucent failing

Project Member Reported by tapted@chromium.org, Jun 27 2016 
Regressed over the weekend.

Chrome Version       : 53.0.2774.3
OS Version: OS X 10.11.5

[ RUN      ] WidgetTest.Transparency_DesktopWidgetTranslucent
[28148:1299:0626/170548:8329881112453:ERROR:native_widget_mac.mm(282)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../ui/views/widget/widget_unittest.cc:3812: Failure
Value of: widget.ShouldWindowContentsBeTransparent()
  Actual: false
Expected: IsNativeWindowTransparent(widget.GetNativeWindow())
Which is: true
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce26dc83bff3f79f27b698f9cddeb7d9470949a

commit 1ce26dc83bff3f79f27b698f9cddeb7d9470949a
Author: tapted <tapted@chromium.org>
Date: Mon Jun 27 03:13:03 2016

Add views_unittests to Mac10.{9,9(dbg),10,11} and asan bots

Disable a few tests we haven't gotten to fixing yet, since it's more
important to get the rest into continuous integration at this point.

Will land this at a quiet time on the weekend, and monitor closely
for potential flakes or other problems.

Recently added tests disabled due to missing GetGlobalCapture()
implementation:
 - MenuRunnerTest.WidgetDoesntTakeCapture
 - WidgetTest.MousePressCausesCapture
 - WidgetTest.CaptureDuringMousePressNotOverridden

Disabled on 10.9 only (different native Textfield behaviour):
 - BridgedNativeWidgetTest.TextInput_MoveEditingCommands
 - BridgedNativeWidgetTest.TextInput_DeleteCommands

Also disables:
 - WidgetTest.FullscreenFrameLayout [fails only on bots]
 - StyledLabelTest.StyledRangeBold [fails only on 10.10]

But the other ~720 tests pass.

Disables tests for recent regressions in r401862 and r401987. We need
that continuous integration - stat!

BUG= 500806 ,  621734 ,  622979 ,  622983 ,  622979 ,  607403 ,  623420 ,  623421 

Review-Url: https://codereview.chromium.org/1925943002
Cr-Commit-Position: refs/heads/master@{#402103}

[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/cocoa/bridged_native_widget_unittest.mm
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/widget/widget_unittest.cc

Comment 2 by tapted@chromium.org, Dec 7 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2552813006/
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c69b77738d6120a4e347cdcc25714fbfc77dc13

commit 4c69b77738d6120a4e347cdcc25714fbfc77dc13
Author: tapted <tapted@chromium.org>
Date: Thu Dec 08 01:54:18 2016

MacViews: Fix CompositingWidgetTest.Transparency_DesktopWidgetTranslucent

NativeWidgetMac::ShouldWindowContentsBeTransparent() always returns
false. The method is used by c/b/ui/views/tab_strip.cc when painting the
tab strip. When the Cocoa browser started supporting translucency around
the tab strip (using NSVisualEffectView) it was too subtle to require
changes around the painting of tabs, so this is probably going to remain
the case.

BUG= 623421 

Review-Url: https://codereview.chromium.org/2552813006
Cr-Commit-Position: refs/heads/master@{#437131}

[modify] https://crrev.com/4c69b77738d6120a4e347cdcc25714fbfc77dc13/ui/views/widget/widget_unittest.cc

Comment 4 by tapted@chromium.org, Dec 8 2016

Status: Fixed (was: Started)

Comment 5 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment