New issue
Advanced search Search tips

Issue 623372 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 613422



Sign in to add a comment

Link to CL

Project Member Reported by no...@chromium.org, Jun 26 2016

Issue description

In tryjobs it would be great to have a link to the CL that the tryjob belongs to.
I've discovered this need when analyzing builds. There is a link from CL to build, but not back
 

Comment 1 by hinoka@chromium.org, Jun 27 2016

Labels: luci-milo

Comment 2 by hinoka@chromium.org, Jun 27 2016

Labels: M-627

Comment 3 by hinoka@chromium.org, Jun 27 2016

Labels: -M-53

Comment 4 by hinoka@chromium.org, Jun 27 2016

Labels: W-0627

Comment 5 by hinoka@chromium.org, Jun 27 2016

Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by hinoka@chromium.org, Jun 28 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/a547622d6472fbe5976d8c030936355464b1316f

commit a547622d6472fbe5976d8c030936355464b1316f
Author: hinoka <hinoka@google.com>
Date: Tue Jun 28 22:30:57 2016

Milo: Extract the rietveld information from buildbot.

So that the CL link can bubble up.

BUG= 623372 

Review-Url: https://codereview.chromium.org/2102903002

[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/build.go
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/expectations/CrWinGoma.30608.build.json
[add] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/html_data.go
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/structs.go
[add] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/buildbot/testdata/buildbot/win_chromium_rel_ng.246309.json
[add] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html
[add] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html
[add] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/frontend/testdata/buildbot/win_chromium_rel_ng.246309.json
[modify] https://crrev.com/a547622d6472fbe5976d8c030936355464b1316f/appengine/cmd/milo/resp/build.go

Comment 8 by hinoka@chromium.org, Jun 28 2016

Status: Fixed (was: Started)

Comment 9 by hinoka@chromium.org, Jun 28 2016

Status: Started (was: Fixed)
Not fixed for swarming
Blockedon: 613422
Owner: no...@chromium.org
+nodir since he'll do this for swarming by virtue of making builder view work.
Labels: -M-627
Labels: -W-0627 W-0704
Labels: W0711
Labels: -W-0704 -W0711 W-0711
Labels: -W-0711 W-0718

Comment 16 by no...@chromium.org, Jul 28 2016

Labels: M-54
Labels: -W-0718 W-0801
Labels: Type-Bug
Labels: -W-0801 W-0815
Labels: -M-54 -luci -luci-milo S-Medium
Labels: -S-Medium S-Small
Mergedinto: 632898
Status: Duplicate (was: Started)

Sign in to add a comment