Middle-click autoscroll not working properly in Windows
Reported by
term...@gmail.com,
Jun 26 2016
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36 Steps to reproduce the problem: 1. In Windows in Chrome go to http://www.ebay.com/itm/1-4-3-8-1-2-Power-Drill-Bit-Driver-Hex-Socket-Bar-Wrench-Adapter-Extension/361307484907 2. Go down to the product description and middle-click to bring up the autoscroll 3. Try dragging the mouse up and down and it does not scroll What is the expected behavior? The expected behavior is it scrolls like it does on other pages. This particular page I'm having the problem with autoscroll works in Firefox. What went wrong? I don't know. I've attached an animated GIF demonstrating the issue. Did this work before? N/A Chrome version: 51.0.2704.103 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Oct 3 2016
,
Oct 4 2016
I was able to reproduce this when the window shrunk horizontally. The pan scrolling code seems to lock onto an individual scroller and not bubble the event if the scroller can't move in that direction. In this case there is a nested scroller that scrolls only horizontally and then the root document scroller which contains the vertical scroll.
,
Oct 4 2016
+ bokan@ for FYI and ideas.
,
Oct 4 2016
Don't have a windows machine on me at the moment to test but I'd guess touch might have the same issue (if we force main thread scrolling)
,
Oct 4 2016
Whelp, never mind, they're separate paths. It's likely an issue in how we chain the scrolls up in LayoutBox::scrollRectToVisible. We should unify it with the wheel/touch paths to share implementation.
,
Nov 4 2016
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4af1f04e6a998799e2dab6633518470dc95d826 commit e4af1f04e6a998799e2dab6633518470dc95d826 Author: sunyunjia <sunyunjia@chromium.org> Date: Wed Nov 16 17:23:11 2016 Determine the layoutobject of middleClickAutoscroll by the scroll direction. Previously, when middleClickAutoscroll is triggered, the layoutObject to be scrolled is only determined by the element clicked. However, if the layoutObject can be scrolled but not in the direction we want, the autoscroll could not be triggered. In this patch, we determine the layoutObject not only by the initial click position, but also the initial scroll direction. We also make sure that when the initial click position is in an iframe, the event will correctly propagate to its owner element. BUG= 623366 Review-Url: https://codereview.chromium.org/2484563003 Cr-Commit-Position: refs/heads/master@{#432534} [add] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-latching.html [add] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/LayoutTests/fast/events/resources/middleClickAutoscroll-iframe.html [modify] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/Source/core/page/AutoscrollController.cpp [modify] https://crrev.com/e4af1f04e6a998799e2dab6633518470dc95d826/third_party/WebKit/Source/core/page/AutoscrollController.h
,
Nov 16 2016
Thank you. If you need me to test the fix please let me know.
,
Nov 23 2016
,
Dec 27 2016
sunyunjia I was wondering when this fix will arrive on stable? Also I have the same problem on https://ultimeyesvision.com/ which seems to use a custom scrollbar. Is it related or should I file a separate issue? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mustaq@chromium.org
, Oct 3 2016Labels: Hotlist-Input-Dev