New issue
Advanced search Search tips

Issue 623344 link

Starred by 18 users

Issue metadata

Status: Fixed
Merged: issue 603217
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 701398



Sign in to add a comment

PIN based login for Chrome OS

Reported by berg...@gmail.com, Jun 25 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8172.60.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
Platform: 8172.60.0 (Official Build) stable-channel gnawty

Steps to reproduce the problem:
1. Setup your Google account on Chrome OS
2. When you log in or unlock your Chromebook you have to type your (hopefully, for security) long and random Google password in each time, which is a pain.
3. Use Chromebook

What is the expected behavior?
The *REQUESTED* behavior would be to be able to use a PIN to sign in/unlock the Chromebook once the user account is setup the first time (like you can in Windows 10, you log into your MS account the first time using the full password, then create a 3-12 character pin to log into the machine or unlock it, while still using the full password on the web). I unlock my Chromebook countless times a day, and typing "12345" would be way easier than typing "goats-alive-SHEEP-dead-87893-@wesco" each time (yes I use passwords that long/complex on my online accounts). Please make it easier to unlock our Chromebooks.

What went wrong?
I couldn't use a PIN to unlock my Chromebook 40+ times a day. Please make it easier to unlock our Chromebooks.

Did this work before? N/A 

Chrome version: 51.0.2704.103  Channel: stable
OS Version: 8172.60.0
Flash Version: Shockwave Flash 22.0 r0

I know this would take effort and energy to get working, but please consider it? I love Chrome OS but I really do hate typing in 38 characters (current Google account password) everytime I need to unlock my Chromebook, I'd much rather just type 3-12 characters and be done.
 

Comment 1 Deleted

Components: Services>SignIn UI>SignIn
Owner: tbuck...@chromium.org
Status: Available (was: Unconfirmed)
Mergedinto: 603217
Status: Duplicate (was: Available)
We're working on this!

Comment 5 by derat@chromium.org, Aug 5 2016

Cc: tbuck...@chromium.org
Owner: ----
Status: Untriaged (was: Duplicate)
Unduping --  issue 603217  is just tracking lock, so I think it makes sense to track login separately so the request doesn't get lost.
Cc: jdufault@chromium.org
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
Cc: -jdufault@chromium.org
Labels: -Pri-2 M-60 Pri-1
Owner: jdufault@chromium.org
Status: Started (was: Assigned)
Blocking: 701398
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af3c577c74d641ba49887e27a54595cd04ef7108

commit af3c577c74d641ba49887e27a54595cd04ef7108
Author: jdufault <jdufault@chromium.org>
Date: Mon Apr 10 23:50:48 2017

cros: Showing pin on lock is no longer associated with sending user list.

The check to see if pin is allowed is going to become an async call in
the future; we should show user list even if pin check hasn't completed yet.

TEST=
- lock screen 1 user w/ & w/o pin
- lock screen 2 user w/ & w/o pin
- chrome user manager (see video in  crbug.com/623917 )
- preloaded lock screen

BUG= 623344 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2785003002
Cr-Commit-Position: refs/heads/master@{#463451}

[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/ui/login/account_picker/screen_account_picker.js
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/af3c577c74d641ba49887e27a54595cd04ef7108/ui/login/screen_container.css

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bb91b6589418cfe73938b74369b520324840ecd

commit 3bb91b6589418cfe73938b74369b520324840ecd
Author: jdufault <jdufault@chromium.org>
Date: Wed Apr 19 19:29:32 2017

cros: Allow JS to control virtual keyboard on sign-in screen.

This also renames the JS<->C++ API; C++ does not need to know about pin.

BUG= 623344 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814863002
Cr-Commit-Position: refs/heads/master@{#465707}

[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/screens/core_oobe_view.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/chromeos/login/ui/webui_login_view.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/3bb91b6589418cfe73938b74369b520324840ecd/ui/login/display_manager.js

Project Member

Comment 14 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa42069f00f64237851e549f94e49c328f1a1fc

commit 8aa42069f00f64237851e549f94e49c328f1a1fc
Author: jdufault <jdufault@chromium.org>
Date: Wed May 31 23:19:23 2017

cros: Refactor oobe LoadUsers to include non-serialized user list.

UI-agnostic login code probably should not be serializing the user list
(that should be done in the *Handlers), but that is a bigger cleanup to
be done later.

BUG= 623344 

Review-Url: https://codereview.chromium.org/2811383002
Cr-Commit-Position: refs/heads/master@{#476086}

[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/signin_screen_controller.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/signin_screen_controller.h
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/chromeos/login/ui/webui_login_display.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/8aa42069f00f64237851e549f94e49c328f1a1fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0917c68019cebeac78edc268d9260452c9b0e765

commit 0917c68019cebeac78edc268d9260452c9b0e765
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Apr 03 19:09:21 2018

cros: Store UserContext in QuickUnlockStorage.

Adding a key to cryptohome requires the associated UserContext. This
adds an AuthToken to quick_unlock which stores the UserContext
instance. The AuthToken automatically expires after a delay.

Bug:  623344 
Change-Id: Ife3373599fb560dfe9f9055fcda54a9f001c6ac7
Reviewed-on: https://chromium-review.googlesource.com/980738
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547785}
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[add] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/login/quick_unlock/auth_token.cc
[add] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/login/quick_unlock/auth_token.h
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.cc
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h
[modify] https://crrev.com/0917c68019cebeac78edc268d9260452c9b0e765/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage_unittest.cc

Since the OS already has the feature and a policy in place, may I ask what is holding up allowing g-suite domains to manage the policy?
> Since the OS already has the feature and a policy in place, may I ask what is holding up allowing g-suite domains to manage the policy?

PIN login is still being worked on; it has a completely separate implementation compared to PIN on lock screen.
Status: Fixed (was: Started)

Sign in to add a comment