New issue
Advanced search Search tips

Issue 623335 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

gclient regression Windows path with whitespace

Reported by max.pitt...@gmail.com, Jun 25 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36 Vivaldi/1.2.490.43

Steps to reproduce the problem:
1. Clone depot_tools to any path with a space in it on Windows, such as "F:\Active Projects\depot_tools"
2. Open a command prompt at the depot_tools path
3. run gclient.bat

What is the expected behavior?
Install normally

What went wrong?
'F:\Active' is not recognized as an internal or external command, operable program, or batch file

Did this work before? Yes Supposedly as of commit 851c8291a3eb25a73b32a070b1e50cd03a2a189e

Chrome version: 51.0.2704.103  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

Replacement lines that fix this problem

bootstrap/win/win_tools.bat:
71:for /d %%i in ("%WIN_TOOLS_ROOT_DIR%\git-*_bin") do (
72:  if not "%%i" == "%WIN_TOOLS_ROOT_DIR%\git-%GIT_VERSION%_bin" (

download_from_google_storage.bat:
10:"%~dp0python" "%~dp0\download_from_google_storage.py" %*

gclient.bat:
14:"%~dp0python" "%~dp0\gclient.py" %*

update_depot_tools.bat:
14:  COPY /Y "%~dp0update_depot_tools.bat" "%TEMP%\update_depot_tools_tmp.bat" >nul
16:  "%TEMP%\update_depot_tools_tmp.bat" "%~dp0" %*
19:set DEPOT_TOOLS_DIR=%~1
 
Labels: Te-NeedsFurtherTriage
Components: Infra
Cc: aga...@chromium.org
Components: -Infra Infra>SDK

Comment 4 by aga...@chromium.org, Jul 18 2016

Max, it looks like you already have a fix outlined in your original bug report. Would you like to upload the change? I'll happily review it for you.
Status: Untriaged (was: Unconfirmed)
Labels: -TE-NeedsfurtherTriage TE-NeedsTriageHelp
Labels: -Via-Wizard -TE-NeedsTriageHelp
Status: Available (was: Untriaged)
This doesn't require further triage; it is available for anyone (including the original author, who appears to have a patch) to take.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 9 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 702057
Status: Duplicate (was: Untriaged)

Sign in to add a comment