New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623296 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
mus



Sign in to add a comment

UserActivityDetector support in mus

Project Member Reported by sadrul@chromium.org, Jun 25 2016

Issue description

Ash and Chrome uses ui::UserActivityDetector (https://cs.chromium.org/chromium/src/ui/base/user_activity/user_activity_detector.h?sq=package:chromium&l=21&dr=CSs) to detect user activity and idleness. This needs to be supported in mus.

Design doc: https://docs.google.com/document/d/1RNzW4vbFjTQA44ILT_jqEf9MCJvxTPbrcmrcW9vYHng/edit#

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2bca7dc696137ca9ae1101b6479ffb69e328577

commit f2bca7dc696137ca9ae1101b6479ffb69e328577
Author: sadrul <sadrul@chromium.org>
Date: Tue Jun 28 03:47:15 2016

mus: Add UserActivityMonitor.

Introduce UserActivityMonitor in mus. Clients can install UserActivityObserver
to get notified of repeated user-activity, and UserIdlenessObserver to get
notified of when the user becomes idle/active.

BUG= 623296 

Review-Url: https://codereview.chromium.org/2094933003
Cr-Commit-Position: refs/heads/master@{#402398}

[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/mus_app.cc
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/mus_app.h
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/public/interfaces/BUILD.gn
[add] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/public/interfaces/user_activity_monitor.mojom
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/BUILD.gn
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/display.cc
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/test_utils.h
[add] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/user_activity_monitor.cc
[add] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/user_activity_monitor.h
[add] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/user_activity_monitor_unittest.cc
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/window_server.cc
[modify] https://crrev.com/f2bca7dc696137ca9ae1101b6479ffb69e328577/components/mus/ws/window_server.h

Status: Fixed (was: Started)
This is done. Filed issue 626899 to track converting the current UserActivityObserver implementations to use the new API.
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment