New issue
Advanced search Search tips

Issue 623269 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 622951



Sign in to add a comment

recipes-py fails because cannot find coverage

Project Member Reported by no...@chromium.org, Jun 25 2016

Issue description

many swarmbucket builds fail because python coverage is not deployed on swarming bots (it shouldn't be)

example:
https://luci-milo.appspot.com/swarming/prod/2f72e0221d2fbd10/steps/recipe_tests/0/stdout


 

Comment 1 by no...@chromium.org, Jun 25 2016

I've cipd-packaged python coverage with compiled C extensions for 5 platforms: 

$ cipd ls infra/coverage-py/cp27/
infra/coverage-py/cp27/linux-386
infra/coverage-py/cp27/linux-amd64
infra/coverage-py/cp27/mac-amd64
infra/coverage-py/cp27/windows-386
infra/coverage-py/cp27/windows-amd64

see also https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/HhXxY3TSeHk
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/e6619143d7a1d72e6bc8ede4de674383a5b3aa39

commit e6619143d7a1d72e6bc8ede4de674383a5b3aa39
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jun 25 02:05:21 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/017a87f445ba0f1c89fc42cba72a3a6382ee589e

commit 017a87f445ba0f1c89fc42cba72a3a6382ee589e
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jun 25 02:24:11 2016

Comment 4 by no...@chromium.org, Jun 25 2016

Status: Fixed (was: Started)
A task with coverage deployed as a cipd package and include in PYTHONPATH
https://chromium-swarm.appspot.com/user/task/2f9e09d7be3fd710

Comment 5 by no...@chromium.org, Jun 29 2016

Status: Assigned (was: Fixed)

Comment 7 by no...@chromium.org, Jun 29 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2107283002/
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/b1931833114a989a4e278398fd214dea83d1ca89

commit b1931833114a989a4e278398fd214dea83d1ca89
Author: nodir <nodir@chromium.org>
Date: Fri Jul 01 20:19:18 2016

kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: special
treatment of PYTHONPATH would be more special in swarming than in
kitchen because swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG= 623269 

Review-Url: https://codereview.chromium.org/2107283002

[modify] https://crrev.com/b1931833114a989a4e278398fd214dea83d1ca89/client/cmd/kitchen/cook.go
[add] https://crrev.com/b1931833114a989a4e278398fd214dea83d1ca89/common/flag/stringlistflag/stringlistflag.go
[add] https://crrev.com/b1931833114a989a4e278398fd214dea83d1ca89/common/flag/stringlistflag/stringlistflag_test.go
[modify] https://crrev.com/b1931833114a989a4e278398fd214dea83d1ca89/common/flag/stringsetflag/stringsetflag_test.go

Project Member

Comment 9 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/e59413fc379e85ea27bf6415c79f4243c996f8d8

commit e59413fc379e85ea27bf6415c79f4243c996f8d8
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jul 02 19:36:01 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/0aa69ed8df6ee6d4ddcaa84d2e168ba77169875e

commit 0aa69ed8df6ee6d4ddcaa84d2e168ba77169875e
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jul 02 19:41:48 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/070d6ecec046f9caa021d93d1b74d8aa205e3a82

commit 070d6ecec046f9caa021d93d1b74d8aa205e3a82
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jul 02 20:00:58 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/c83545429bd823d84f2d1df901579f910086cec0

commit c83545429bd823d84f2d1df901579f910086cec0
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Jul 07 15:34:59 2016

Status: Verified (was: Started)
analysis in https://bugs.chromium.org/p/chromium/issues/detail?id=622951#c11 show that there were no failure due to this bug after #13

Sign in to add a comment