bookmarks manager: opening 15+ bookmarks broken (with --enable-experimental-web-platform-features) |
|||
Issue descriptionThe bookmarks manager uses bookmarksPrivate to ask how many bookmarks in a directory. This API is asynchronous. After a user chooses to open a folder full of bookmarks, we prompt (if there's 15+ bookmarks found) asking "Do you really want to open 20 bookmarks?". That's currently implemented via confirm(), which was disallowed from microtasks (i.e. after we get our async API response) as of https://codereview.chromium.org/1126253007 (or one of the CLs in https://bugs.chromium.org/p/chromium/issues/detail?id=483624). Let's figure out either a way to: a) figure out the number of URLs to be opened synchronously b) how to sidestep this security measure for the bookmarks manager
,
Jun 25 2016
If the sandbox change is the blocking factor, you can change the sandboxing flags on the frame which uses `confirm()` to include `allow-modals`.
,
Jun 25 2016
Please consider using a <dialog> instead of a prompt()
,
Jun 26 2016
I tried this on Mac and Linux, and they both show "An embedded page at ... says: Are you sure ...". How exactly do you reproduce this being blocked? On bookmarks bar, the prompt is "Chromium: Are you sure ...". Do we want to make them look the same?
,
Jun 27 2016
mkwst@: yeah, I'll think about that / try to find out how to apply that to my UI jochen@: I agree the UI is bad and something like <dialog> is a better answer wychen@: chrome://flags/#enable-experimental-web-platform-features (sorry, didn't know this is required)
,
Apr 3 2017
Yes, PLEASE do not use a dialog. Please use something like <dialog>.
,
Apr 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Jun 25 2016