Bookmarking an offline copy, creates a bookmark to the file://.. path |
|||||
Issue descriptionVersion: 53.0.2774.4 OS: Android L Bookmarking an offline copy, will create a bookmark to the file://.. path instead of the source url. If the file ever changes, clicking on the bookmark will just lead to file not found error. What steps will reproduce the problem? (1) Open Chrome 53.0.2774.4 with offline pages enabled (2) Through Last N save an offline copy (3) Go offline, view the copy #2 (4) Bookmark the offline copy What is the expected output? A bookmark will be created to the source url (for example xkcd.com) What do you see instead? A bookmark is created for the file://... location of the offline copy. If the file ever gets moved, or replaced a file not found error will occur on clicking. Please use labels and text to provide additional information.
,
Jun 29 2016
,
Jul 14 2016
Users likely expect the bookmark to point to original site. We need to create bookmark with online URL in this case.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e09dff921a487d398749812d35804267d883aa55 commit e09dff921a487d398749812d35804267d883aa55 Author: romax <romax@chromium.org> Date: Mon Jul 25 18:22:19 2016 [Offline Pages] Fixing bookmarking offline page will save file path. Fixing the issue where in offline mode, bookmarking an offline page would save the file path instead of the original path. BUG= 623243 Review-Url: https://codereview.chromium.org/2144423002 Cr-Commit-Position: refs/heads/master@{#407520} [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/e09dff921a487d398749812d35804267d883aa55/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
,
Jul 25 2016
,
Aug 1 2016
Verified Fixed in 54.0.2812.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by romax@chromium.org
, Jun 25 2016Status: Assigned (was: Untriaged)