New issue
Advanced search Search tips

Issue 623242 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Control background auto resumption

Project Member Reported by qin...@chromium.org, Jun 24 2016

Issue description

When a download is in progress and chrome gets killed, we will relaunch the browser process for background resumption.
However, things could go viral if chrome got killed again due to OOM and then relaunch itself.

Add some controls on this
 
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c0e04cb04c53076b464486d84ea0f9bf764698

commit f9c0e04cb04c53076b464486d84ea0f9bf764698
Author: qinmin <qinmin@chromium.org>
Date: Tue Jun 28 00:20:56 2016

capping how many times background download resumption can automatically start

If download gets interrupted due to browser kill, we schedule a browser
restart.
And we could stuck in a cycle of kill->restart->kill.
This CL caps the number of auto resumptions.
And reset the cap when user relaunches chrome.

BUG= 623242 

Review-Url: https://codereview.chromium.org/2094033002
Cr-Commit-Position: refs/heads/master@{#402340}

[modify] https://crrev.com/f9c0e04cb04c53076b464486d84ea0f9bf764698/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/f9c0e04cb04c53076b464486d84ea0f9bf764698/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/f9c0e04cb04c53076b464486d84ea0f9bf764698/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Comment 3 by qin...@chromium.org, Aug 10 2016

Status: Fixed (was: Assigned)

Sign in to add a comment