Catch uninitialized bytes in IPC messages while still in a useful stack trace |
||
Issue descriptionIf there are uninitialized bytes in any outgoing IPC messages sent from off the IO thread (i.e. most IPC messages), memory bots will flag an uninitialized read which contains no useful information in the stack trace. This leads to blanket suppressions being added to green the bots while masking all such bugs and hiding the underlying source of trouble. We should find a way to trigger uninit read detection at the call site of the original IPC Send without impacting performance so we can get useful stack traces.
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf1598991bbbf0a9b34764a37a9c1b97ea50ca4f commit bf1598991bbbf0a9b34764a37a9c1b97ea50ca4f Author: rockot <rockot@chromium.org> Date: Fri Jun 24 23:33:42 2016 Remove uninit read suppression for Mojo EDK writes This is a common codepath through which all IPC data is transmitted. Suppressing this supresses all potential uninitialized read bugs in any code which prepares IPC messages for transit (e.g. any IPC::ParamTraits implementation.) This suppression was recently relanded as a result of an uninitialized read in some IPC message contents. It's possible that the actual bug has been fixed, but it's unclear. Since I'm unable to repro locally I'm removing the suppression to see if the memory bots go red again. Memory sheriffs *please* ping rockot@ before relanding this suppression. BUG= 398547 , 623235 TBR=amistry@chromium.org Review-Url: https://codereview.chromium.org/2098963002 Cr-Commit-Position: refs/heads/master@{#402013} [modify] https://crrev.com/bf1598991bbbf0a9b34764a37a9c1b97ea50ca4f/tools/valgrind/drmemory/suppressions_full.txt
,
Jun 25 2016
Actually, looks like base::Pickle already uses MSAN_CHECK_MEM_IS_INITIALIZED so this bug is invalid. If uninit bytes show up again they must be coming from somewhere else. |
||
►
Sign in to add a comment |
||
Comment 1 by roc...@chromium.org
, Jun 24 2016