New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623228 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in task manager for unresponsive OOPIF

Project Member Reported by creis@chromium.org, Jun 24 2016

Issue description

Version: 53.0.2778.0
OS: Windows, Linux

What steps will reproduce the problem?
1) Start debug build of Chrome with --site-per-process and open Task Manager.
2) Visit http://csreis.github.io/tests/cross-site-iframe.html.
3) Click "Go cross-site (simple page)"
4) Right click inside the iframe and open DevTools.  (Important, so that we're
inspecting the OOPIF's page.)
5) Type "while (1);" in the console.
6) Try to select text in the iframe and wait 20 seconds.

What is the expected output?

The unresponsiveness dialog should be shown.

What do you see instead?

The browser crashes on a DCHECK in WebContentsEntry::OnRendererUnresponsive:
DCHECK_EQ(render_widget_host->GetProcess(),
          web_contents()->GetMainFrame()->GetProcess());

This isn't a safe assumption to make-- any widget in the tab might become unresponsive, even those in out-of-process iframes.  Looks like the bug is that we end up notifying other code (the processes extension API) that the main frame's process is unresponsive when it's really a different frame's process.

(Note that fixing this bug probably won't be sufficient to get the unresponsiveness dialog to appear for OOPIFs; we can file another bug if needed.)
 

Comment 1 by creis@chromium.org, Oct 18 2016

Labels: -Pri-3 M-56 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Now that OOPIFs are starting to ship, we need to get this resolved.  (I just hit it again in a debug build.)  afakhry@ or nick@, will you have time to take a look, or should I try to put together a CL?

I'm concerned that this isn't the only place in WebContentsEntry that has OOPIF bugs.  DidFinishNavigation is also assuming it's for the main frame, though it's not clear whether that has a visible impact.  (We don't show favicons or titles for subframes.)

Comment 2 by creis@chromium.org, Oct 19 2016

Cc: afakhry@chromium.org
Owner: creis@chromium.org
Status: Started (was: Assigned)
I've got a CL started at https://codereview.chromium.org/2427423003/.  Seeing if I can add a test.

Comment 4 by creis@chromium.org, May 1 2017

Status: Fixed (was: Started)

Sign in to add a comment