New issue
Advanced search Search tips

Issue 623216 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Pass in all extras required to display awesome splashscreens for WebAPKs

Project Member Reported by pkotw...@chromium.org, Jun 24 2016

Issue description

Currently, only a subset of the extras handled by WebappInfo are passed to WebappLauncherActivity. We should pass all of them in order to get awesome splash screens
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8678dfec2891e16e637db2459125edd32fe3c91

commit f8678dfec2891e16e637db2459125edd32fe3c91
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed Jun 29 22:37:46 2016

Pass all intent extras needed to render splash screen when launching WebAPK

This CL adds to the WebAPK's Android Manifest  attributes for rendering the
splash screen. These attributes are passed to WebappActivity.

The "string value" for the display and orientation attributes is used in the
WebAPK's Android Manifest instead of the WebDisplayMode and
ScreenOrientationValues enum values. This is done to enable WebAPKs to work with
non-Chrome browsers in the future.

BUG= 623216 
TEST=WebappInfoTest
R=hanxi, dominickn
TBR=dfalcantara

Review-Url: https://codereview.chromium.org/2094903003
Cr-Commit-Position: refs/heads/master@{#402965}

[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/AndroidManifest.xml
[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/BUILD.gn
[modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Blocking: -524670
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9ba50d1cc7b0951b94c2b3bd236a03896258ceb0

commit 9ba50d1cc7b0951b94c2b3bd236a03896258ceb0
Author: Peter Kotwicz <pkotwicz@google.com>
Date: Fri Jul 01 22:08:12 2016

Sign in to add a comment