Currently, only a subset of the extras handled by WebappInfo are passed to WebappLauncherActivity. We should pass all of them in order to get awesome splash screens
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8678dfec2891e16e637db2459125edd32fe3c91 commit f8678dfec2891e16e637db2459125edd32fe3c91 Author: pkotwicz <pkotwicz@chromium.org> Date: Wed Jun 29 22:37:46 2016 Pass all intent extras needed to render splash screen when launching WebAPK This CL adds to the WebAPK's Android Manifest attributes for rendering the splash screen. These attributes are passed to WebappActivity. The "string value" for the display and orientation attributes is used in the WebAPK's Android Manifest instead of the WebDisplayMode and ScreenOrientationValues enum values. This is done to enable WebAPKs to work with non-Chrome browsers in the future. BUG= 623216 TEST=WebappInfoTest R=hanxi, dominickn TBR=dfalcantara Review-Url: https://codereview.chromium.org/2094903003 Cr-Commit-Position: refs/heads/master@{#402965} [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/AndroidManifest.xml [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/f8678dfec2891e16e637db2459125edd32fe3c91/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a796d935d40d5453cbeeb21ac308c88a68622f8f commit a796d935d40d5453cbeeb21ac308c88a68622f8f Author: pkotwicz <pkotwicz@chromium.org> Date: Thu Jun 30 22:03:43 2016 Pass ShortcutHelper.EXTRA_SOURCE when WebAPK is launched from notification This enables us to keep track of how often WebAPKs are launched from a notification vs from the home screen. BUG= 623216 Review-Url: https://codereview.chromium.org/2094113002 Cr-Commit-Position: refs/heads/master@{#403307} [modify] https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java [modify] https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f/chrome/android/webapk/libs/client/BUILD.gn [rename] https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkNavigationClient.java [modify] https://crrev.com/a796d935d40d5453cbeeb21ac308c88a68622f8f/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/9ba50d1cc7b0951b94c2b3bd236a03896258ceb0 commit 9ba50d1cc7b0951b94c2b3bd236a03896258ceb0 Author: Peter Kotwicz <pkotwicz@google.com> Date: Fri Jul 01 22:08:12 2016
Comment 1 by bugdroid1@chromium.org
, Jun 29 2016