New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623212 link

Starred by 1 user
Status: Verified
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
jamescook@chromium.org
█ patricia@chromium.org
dchan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

focus_cycler_unittest should GetStatusAreaWidget from ash/test

Project Member Reported by warx@chromium.org, Jun 24 2016 
In focus_cycler_unittest, status_area_widget is initialized as
StatusAreaWidget* widget = new StatusAreaWidget(parent, GetPrimaryShelf());

We should use ash/test/status_area_widget_test_helper to avoid possible UAF, which might be corrupted in production code.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f39741962076e661a559cab8d9bdacdcb02badc

commit 7f39741962076e661a559cab8d9bdacdcb02badc
Author: warx <warx@chromium.org>
Date: Sat Jun 25 00:12:56 2016

GetStatusAreaWidget from ash/test in focus_cycler_unittest

BUG= 623212 
TEST=focus_cycler_unittest passes
When CL from https://codereview.chromium.org/2087703002/ applied, asan test also passes.
AddressSanitizer: heap-use-after-free is fixed.

Review-Url: https://codereview.chromium.org/2096153002
Cr-Commit-Position: refs/heads/master@{#402024}

[modify] https://crrev.com/7f39741962076e661a559cab8d9bdacdcb02badc/ash/focus_cycler_unittest.cc

Comment 2 by warx@chromium.org, Jun 25 2016

Status: Fixed (was: Assigned)

Comment 3 by patricia@chromium.org, Jul 1 2016

Status: Verified (was: Fixed)
Bulk verified
►

Sign in to add a comment