OOPIF: layout tests for devtools extensions time out with --site-per-process |
|||
Issue description
Sample repro:
third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn-debug --additional-driver-flag=--isolate-extensions http/tests/inspector/extensions-headers.html --driver-logging --full-results-html
Affected tests:
http/tests/inspector/extensions-headers.html [ Timeout ]
http/tests/inspector/extensions-iframe-eval.html [ Timeout ]
http/tests/inspector/extensions-ignore-cache.html [ Timeout ]
http/tests/inspector/extensions-network-redirect.html [ Timeout ]
http/tests/inspector/extensions-useragent.html [ Timeout ]
These tests are already disabled for --site-per-process.
The problem seems to be that the DevTools extension page is loaded in a different process from the devtools process. For the extensions-headers.html test in the repro, the extension is loaded off of http://127.0.0.1:8000//inspector/resources/extension-main.html, while the rest of devtools is apparently at a file:// URL that looks like file:///<path_to_build_dir>/resources/inspector/inspector.html?experiments=true&settings={%22testPath%22:%22\\%22http://127.0.0.1:8000/inspector/extensions-headers.html\\%22%22. We currently keep DevTools extensions in-process with some longer-term plans for stronger isolation (see issue 570483 ), but the corresponding check in RenderFrameHostManager::IsRendererTransferNeededForNavigation relies on DevTools being loaded from a kChromeDevToolsScheme, which is apparently not true with layout tests. The test fails after the extension page tries to access window._extensionServerForTests.sendRequest, which fails because _extensionServerForTests is undefined.
These tests work fine with --isolate-extensions.
,
Apr 6 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b51a81e48c43becbb456ff0f0820abd950ac2834 commit b51a81e48c43becbb456ff0f0820abd950ac2834 Author: Alex Moshchuk <alexmos@chromium.org> Date: Thu Jul 20 17:46:53 2017 Re-enable --site-per-process layout tests that have healed themselves. NOTRY=true Bug: 710098 , 623268 , 623210 , 680307 Change-Id: I3b086fb6310ba8216cbade6cae6de08e689d460d Reviewed-on: https://chromium-review.googlesource.com/579891 Reviewed-by: Lukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#488295} [modify] https://crrev.com/b51a81e48c43becbb456ff0f0820abd950ac2834/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Jul 25 2017
I suspect these tests were fixed as part of the work that pfeldman@ did to kick DevTools extensions out of process in issue 706169 . |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 25 2016