Issue metadata
Sign in to add a comment
|
Omnibox synchronously unhides on navigation |
||||||||||||||||||||||
Issue descriptionVersion: 530.02774.4/dev OS: Android What steps will reproduce the problem? (1) Visit any page, https://news.ycombinator.com works. (2) Scroll up and down so that the Omnibox hides (3) Click one of the comment links (4) Notice that before the next page loads, the page jumps so you are unsure if you clicked the right link. What is the expected output? The link should not move out from under your finger. What do you see instead? The link moves out from under your finger. Please use labels and text to provide additional information. This is a regression from M51
,
Jun 24 2016
No repro on 52.0.2743.0, but I can repro on 53.0.2770.0. I initially suspected r401588, but this is actually outside the regression range. Anyway, bokan@, could you investigate?
,
Jun 27 2016
,
Jun 27 2016
Actually, r401588 would not have made the 52 branch and reverting it does fix the issue. The problem is that we shouldn't set the main thread shown_ratio when the state change is animated. I've got a simple fix for that.
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/849f8df4aa51c333cd14286b51673acc90e9b862 commit 849f8df4aa51c333cd14286b51673acc90e9b862 Author: bokan <bokan@chromium.org> Date: Wed Jun 29 17:57:32 2016 Don't set shownRatio in main thread top controls on animated state change. In r399036 I made the main thread set the shown ratio as soon as a state change came in so that the updated window height would be available to script immediately. This causes problems when the state change is animated since the compositor thread will try to animate to the state and it'll fight with the commited value coming from the main thread. This CL simply disables the main thread behavior when the state change should be animated, relying on the compositor to drive the animation. BUG= 623183 Review-Url: https://codereview.chromium.org/2105523002 Cr-Commit-Position: refs/heads/master@{#402867} [modify] https://crrev.com/849f8df4aa51c333cd14286b51673acc90e9b862/third_party/WebKit/Source/core/frame/TopControls.cpp [modify] https://crrev.com/849f8df4aa51c333cd14286b51673acc90e9b862/third_party/WebKit/Source/core/frame/TopControls.h [modify] https://crrev.com/849f8df4aa51c333cd14286b51673acc90e9b862/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/849f8df4aa51c333cd14286b51673acc90e9b862/third_party/WebKit/Source/web/tests/TopControlsTest.cpp
,
Jun 29 2016
This should be fixed in ToT, please reopen if you're still seeing it in upcoming releases. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pdr@chromium.org
, Jun 24 2016