New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623171 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit 26 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

64%-88.6% regression in smoothness.gpu_rasterization.tough_filters_cases at 401756:401811

Project Member Reported by mustaq@chromium.org, Jun 24 2016

Issue description

See the link to graphs below.
 

Comment 1 by mustaq@chromium.org, Jun 24 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=623171

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgorzhqQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgopS5sAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwqulrwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win10
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mustaq, can you follow up on this?

From the instructions (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_regression_sheriffing.md):
"After your shift, please try to follow up on the bugs you filed weekly. Kick off new bisects if the previous ones failed, and if the bisect picks a likely culprit follow up to ensure the CL author addresses the problem. If you are certain that a specific CL caused a performance regression, and the author does not have an immediate plan to address the problem, please revert the CL."

Comment 4 by mustaq@chromium.org, Jul 11 2016

Restarted 2 bisects, removed a recovered alert.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 11 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@401755  55.7438  5.13024  18  good
chromium@401811  56.1012  2.11949  18  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 623171

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.gpu_rasterization.tough_filters_cases
Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100
Relative Change: 5.31%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2024
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007407977102148160


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5829619614220288

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jul 12 2016

Cc: brettw@chromium.org
Owner: brettw@chromium.org

=== Auto-CCing suspected CL author brettw@chromium.org ===

Hi brettw@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Make GN components static libraries on Win x64
Author  : brettw
Commit description:
  
For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB.

There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB.

So we can now disable the special case for this configuration.

BUG= 619949 

Review-Url: https://codereview.chromium.org/2098673002
Cr-Commit-Position: refs/heads/master@{#401800}
Commit  : d28aba56dde82051680f9048daf1b1501b9bd89a
Date    : Fri Jun 24 03:06:55 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@401755  36.7767  0.490426  5  good
chromium@401784  36.3788  0.716674  5  good
chromium@401798  40.13    0.999088  5  good
chromium@401799  40.6724  0.959044  5  good
chromium@401800  64.4541  3.45329   5  bad    <--
chromium@401802  62.5755  5.91511   5  bad
chromium@401805  63.0256  2.34782   5  bad
chromium@401811  64.5345  3.3695    5  bad

Bisect job ran on: win_x64_perf_bisect
Bug ID: 623171

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.gpu_rasterization.tough_filters_cases
Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100
Relative Change: 75.48%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_x64_perf_bisect/builds/1313
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007407994097638448


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5893654892249088

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Brett, any chance this could cause a regression in smoothness? The machines are right (two of them are explicitly x64, I'm not sure what the Win10 one is).
Perf sheriff ping: reminder to follow up on possible performance issues
Ping brettw@, can you look into whether your build change cause this regression?
Status: WontFix (was: Assigned)
This has recovered.

Sign in to add a comment