New issue
Advanced search Search tips

Issue 623167 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 623174
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-54.7% regression in smoothness.top_25_smooth at 401756:401811

Project Member Reported by mustaq@chromium.org, Jun 24 2016

Issue description

See the link to graphs below.
 

Comment 1 by mustaq@chromium.org, Jun 24 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=623167

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwoufuAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgws-XqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgws-DsQkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-win7-x64-dual
linux-release
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mustaq, can you follow up on this?

From the instructions (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_regression_sheriffing.md):
"After your shift, please try to follow up on the bugs you filed weekly. Kick off new bisects if the previous ones failed, and if the bisect picks a likely culprit follow up to ensure the CL author addresses the problem. If you are certain that a specific CL caused a performance regression, and the author does not have an immediate plan to address the problem, please revert the CL."

Comment 4 by mustaq@chromium.org, Jul 11 2016

Removed recovered alerts, kicked off separate bisects for the 2 valid cases.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jul 12 2016

Mergedinto: 623174
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Turn on enable begin frame scheduling by default
Author  : enne
Commit description:
  
This turns on --enable-begin-frame-scheduling[1] for all[2] platforms.
This was already on for Android so should only be a real change
for desktop / ChromeOS platforms.

Lots of cleanup can follow from this like removing all commit vsync /
authoritative vsync / CompositorVSyncManager things, but this is a
smaller patch to suss out any performance regressions.

[1] In this case, "begin frame scheduling" means browser->renderer
begin frame ticks instead of sending vsync information and having
a synthetic source on the renderer side.

[2] MUS is not hooked up to begin frame scheduling yet, but
mojo:mash_session in an "oxygen" build still works with this patch
applied.  Blimp also doesn't use begin frame scheduling and will
eventually just be transitioned to a synthetic begin frame source
for its engine half.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1939253002
Cr-Commit-Position: refs/heads/master@{#401796}
Commit  : f2d7f5e1891703ec4384ededd80f896816921204
Date    : Fri Jun 24 02:43:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@401713  19.3593  0.167589   8  good
chromium@401759  19.4256  0.205251   8  good
chromium@401784  19.3178  0.0791277  5  good
chromium@401794  19.3221  0.0712429  8  good
chromium@401795  19.3544  0.124502   5  good
chromium@401796  20.0084  0.243261   5  bad    <--
chromium@401797  20.1182  0.280642   5  bad
chromium@401799  19.838   0.337981   8  bad
chromium@401804  19.8236  0.30457    8  bad

Bisect job ran on: win_perf_bisect
Bug ID: 623167

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/Wikipedia (1 tab)
Relative Change: 2.34%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6685
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007408264421575680


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5829905766416384

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment