New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623164 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

TestMojoMediaClient doesn't support multiple service instances

Project Member Reported by xhw...@chromium.org, Jun 24 2016

Issue description

Steps to repro:

(1) Build GN to run mojo media app in the utility process, with "renderer" service and enable_test_mojo_media_client enabled.

use_goma = true
enable_mojo_media = true
mojo_media_host = "utility"
mojo_media_services = ["renderer"]
is_debug = true
enable_nacl = false
ffmpeg_branding = "ChromeOS"
proprietary_codecs = true
enable_test_mojo_media_client = true

(2) Build and launch Chrome

(3) Play HTML5 audio in one tab.

(4) Play HTML5 audio in a second tab.

Then I hit this crash:

[1:1:0624/132046:FATAL:audio_output_stream_sink.cc(30)] Check failed: !started_.
#0 0x7f9fa0aa24be base::debug::StackTrace::StackTrace()
#1 0x7f9fa0ae2ecf logging::LogMessage::~LogMessage()
#2 0x7f9f99d1ba1e media::AudioOutputStreamSink::Initialize()
#3 0x7f9fa5a76cc8 media::AudioRendererImpl::OnAudioBufferStreamInitialized()
#4 0x7f9f99a1780b _ZN4base8internal15RunnableAdapterIMN5media12PipelineImplEFvbEE3RunIRKNS_7WeakPtrIS3_EEJRKbEEEvOT_DpOT0_
#5 0x7f9f99a1773f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRNS0_15RunnableAdapterIMN5media12PipelineImplEFvbEEERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_
#6 0x7f9fa5a7c126 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN5media17AudioRendererImplEFvbEEEFvPS7_bEJNS_7WeakPtrIS7_EEEEELb1EFvbEE3RunEPNS0_13BindStateBaseEOb
#7 0x7f9f99195407 base::Callback<>::Run()
#8 0x7f9fa5a52ceb media::DecoderStream<>::OnDecoderSelected()

The reason is that all RendererServices running in the utility process share the same AudioOutputStreamSink[1], and it appears that AudioOutputStreamSink cannot be started twice.

[1] https://cs.chromium.org/chromium/src/media/mojo/services/test_mojo_media_client.cc?rcl=0&l=62
 

Comment 1 by xhw...@chromium.org, Jun 24 2016

Cc: tianyuwang@chromium.org
We actually create one sink for each player on Desktop. Maybe TestMojoMediaClient should just do the same.

https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?rcl=1466781696&l=231

Actually https://chromiumcodereview.appspot.com/2016053003/ refactors TestMojoMediaClient, maybe we should fix this after that is landed. 
Owner: xhw...@chromium.org
Not sure whether this is still happening. Assign to myself to check.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by xhw...@chromium.org, Dec 11 2017

Status: WontFix (was: Untriaged)
I plan to drop enable_test_mojo_media_client support since it's not used any more. Mark this issue as WontFix.

Sign in to add a comment