Issue 623157 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	sadrul@chromium.org
Closed:	Aug 2016
Cc:	█ fsam...@chromium.org rjkroege@chromium.org sadrul@chromium.org █ roc...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	1
Type:	Bug

Blocking:
issue 630893

Enable chrome GPU command buffer on Windows

Project Member Reported by staraz@chromium.org, Jun 24 2016

Issue description

Running with Chrome GPU command buffer as default breaks the unit tests run by Windows trybots.
The results of the trybots run are at: https://codereview.chromium.org/2097533005/#ps1

Kludges have been added to use mojo GPU command buffer whenever running on Windows.

Comment 1 by sadrul@chromium.org, Jul 8 2016

Labels: -Pri-3 Pri-1

Would it be possible to trigger another set of tryjobs and collect the errors from the trybots in this bug? The links from the CLs have already expired.

Fixing this would allow removing a bunch of code. We should prioritize it.

Comment 2 by staraz@chromium.org, Jul 11 2016

Please find the error messages from win_chromium_x64_rel_ng attached.

win_chromium_x64_rel_ng_error.txt
147 KB View Download

Comment 3 by penghuang@chromium.org, Jul 11 2016

Cc: rjkroege@chromium.org fsam...@chromium.org sadrul@chromium.org

mus_ws_unittests & mash_unittests crash on Windows. Seems it is because we don't setup IPC AttachmentBroker correctly.



Log:
[0711/110756:ERROR:stack_trace_win.cc(64)] SymInitialize failed: 87

[0711/110756:FATAL:ipc_channel_win.cc(105)] Check failed: GetAttachmentBroker(). 

Error initializing symbols (87).  Dumping unresolved backtrace:

Comment 4 by sadrul@chromium.org, Jul 11 2016

From the attached log, the failure seems to be different?

[ RUN      ] WindowServerTest.RootWindow
[0711/080253:ERROR:stack_trace_win.cc(64)] SymInitialize failed: 87
[0711/080253:FATAL:gl_factory.cc(23)] Check failed: kGLImplementationNone == GetGLImplementation() (0 vs. 3)
Error initializing symbols (87).  Dumping unresolved backtrace:
	000007FEEB7010D1
	000007FEEB6C7EEC
	....

Comment 5 by penghuang@chromium.org, Jul 11 2016

I created a CL to enable chrome gpu command buffer on Windows. And I got the different log.

https://codereview.chromium.org/2135713002/
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/242716

Comment 6 by penghuang@chromium.org, Jul 13 2016

Find out there is an issue during sending file handles via ChannelHandle backed by mojo IPC.


See the log:
[129/190] WindowFinderTest.FindDeepestVisibleWindowHitTestMask (0 ms)
[ RUN      ] WindowServerTest.RootWindow

[0711/110756:ERROR:command_buffer_proxy_impl.cc(232)] Failed to send GpuChannelMsg_CreateCommandBuffer.

Backtrace:

	gpu::CommandBufferProxyImpl::CheckLock [0x000007FEEC5F05B2+14]

	gpu::CommandBufferProxyImpl::SetSwapBuffersCompletionCallback [0x000007FEEC5F28D9+21]

	ui::SurfacesContextProvider::SurfacesContextProvider [0x000007FEEC63C8BC+608]

	ui::DisplayCompositor::DisplayCompositor [0x000007FEEC63C037+259]

	ui::ws::FrameGenerator::OnAcceleratedWidgetAvailable [0x000007FEEC64A1A4+84]

	ui::ws::DefaultPlatformDisplay::OnAcceleratedWidgetAvailable [0x000007FEEC64BC16+26]

	ui::WinWindow::_ProcessWindowMessage [0x000007FEECA29CA6+486]

	ui::WinWindow::ProcessWindowMessage [0x000007FEECA29980+56]

	gfx::WindowImpl::OnWndProc [0x000007FEECA5FE98+84]

	gfx::WindowImpl::WndProc [0x000007FEECA602C8+180]

	base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc> [0x000007FEECA5F7DF+15]

	GetWindowDC [0x00000000777A8971+129]

	SetWindowTextW [0x00000000777A72CB+631]

	SendMessageTimeoutW [0x00000000777A0795+3285]

	KiUserCallbackDispatcher [0x00000000778DD8F5+31]

	SendMessageTimeoutW [0x00000000777A041A+2394]

	SendMessageTimeoutW [0x00000000777A0397+2263]

	SendMessageTimeoutW [0x00000000777A05D8+2840]

	CreateWindowExW [0x00000000777A0880+112]

	gfx::WindowImpl::Init [0x000007FEECA5FC28+380]

	ui::WinWindow::WinWindow [0x000007FEECA29493+191]

	ui::ws::DefaultPlatformDisplay::Init [0x000007FEEC64BBB8+64]

	ui::ws::Display::Display [0x000007FEEC64286D+377]

	ui::ws::WindowTreeHostFactory::CreateWindowTreeHost [0x000007FEEC66687F+67]

	ui::mojom::WindowTreeHostFactoryStub::Accept [0x000007FEEC52A91F+711]

	mojo::internal::Router::HandleMessageInternal [0x000007FEEC503755+733]

	mojo::internal::Router::HandleIncomingMessage [0x000007FEEC503462+454]

	ui::mojom::WindowTreeHostFactoryRequestValidator::Accept [0x000007FEEC52A638+192]

	mojo::MessageHeaderValidator::Accept [0x000007FEEC4FBA96+218]

	mojo::Connector::ReadSingleMessage [0x000007FEEC4F7933+179]

	mojo::Connector::ReadAllAvailableMessages [0x000007FEEC4F785B+31]

	mojo::Connector::OnHandleReadyInternal [0x000007FEEC4F75B4+140]

	mojo::Watcher::OnHandleReady [0x000007FEEC50732A+186]

	base::internal::Invoker<base::internal::BindState<void (__cdecl mojo::Watcher::*)(unsigned int) __ptr64,base::WeakPtr<mojo::Watcher>,unsigned int>,void __cdecl(void)>::RunImpl<void (__cdecl mojo::Watcher::*const & __ptr64)(unsigned int) __ptr64,std::tuple [0x000007FEEC9EE026+86]

	base::debug::TaskAnnotator::RunTask [0x000007FEEC6A60AC+316]

	base::MessageLoop::RunTask [0x000007FEEC66D41C+876]

	base::MessageLoop::DoWork [0x000007FEEC66C82B+411]

	base::MessagePumpForUI::DoRunLoop [0x000007FEEC6A75A8+120]

	base::MessagePumpWin::Run [0x000007FEEC6A8474+84]

	base::RunLoop::Run [0x000007FEEC67BB6E+46]

	shell::ApplicationRunner::Run [0x000007FEEC4F0B41+369]

	MojoMain [0x000007FEEC4E88B9+73]

	shell::RunNativeApplication [0x000000013F416F9D+293]

	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(HINSTANCE__ * __ptr64,mojo::InterfaceRequest<shell::mojom::Service>),HINSTANCE__ * __ptr64>,void __cdecl(mojo::InterfaceRequest<shell::mojom::Service>)>::Run [0x000000013F414E2D+113]

	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(HINSTANCE__ * __ptr64,mojo::InterfaceRequest<shell::mojom::Service>),HINSTANCE__ * __ptr64>,void __cdecl(mojo::InterfaceRequest<shell::mojom::Service>)>::Run [0x000000013F414DE8+44]

	shell::ChildProcessMainWithCallback [0x000000013F416B57+575]

	shell::ChildProcessMain [0x000000013F414D83+343]

	main [0x000000013F41707C+76]

	__scrt_common_main_seh [0x000000013F859DC4+292] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255)

	BaseThreadInitThunk [0x0000000077685A4D+13]

	RtlUserThreadStart [0x00000000778BB831+33]

[4856:4144:0711/110757:8367176:ERROR:node_channel.cc(828)] Failed to duplicate one or more outgoing handles.

e:\b\build\slave\win\build\src\services\ui\public\cpp\tests\window_server_test_base.cc(72): error: Value of: DoRunLoopWithTimeout()

  Actual: false

Expected: true

[4468:3608:0711/110806:8376645:ERROR:node_controller.cc(1066)] Could not be introduced to peer 245332288C7573A2.2C2C1C4667CC55EC

[  FAILED  ] WindowServerTest.RootWindow (10079 ms)

Comment 7 by penghuang@chromium.org, Jul 13 2016

Cc: roc...@chromium.org

Comment 8 by fsam...@chromium.org, Jul 25 2016

Blocking: 630893

Comment 9 by penghuang@chromium.org, Jul 25 2016

Blockedon: 631143

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4628518ceaafa1f53bc0903dcf5fff3c61635ac

commit d4628518ceaafa1f53bc0903dcf5fff3c61635ac
Author: sadrul <sadrul@chromium.org>
Date: Wed Jul 27 19:05:08 2016

services/ui: Remove deprecated gpu code

Summary of changes:
. Move RasterThreadHelper into the client lib, since it's used by mus
  clients (views).
. Remove the --use-mojo-gpu-command-buffer-in-mus flag, which means
  chrome gpu command buffer is now used on Windows for mus.
. Delete the rest of the code in services/ui/gles2, and
  OzoneGpuMemoryBuffer from services/ui/surfaces.

BUG= 623157 ,  630893 

Review-Url: https://codereview.chromium.org/2176303002
Cr-Commit-Position: refs/heads/master@{#408207}

[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/BUILD.gn
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/gpu_service.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/gpu_service.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/switches.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/switches.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/BUILD.gn
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/DEPS
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/OWNERS
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver_manager.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver_manager.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_impl.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_impl.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local_client.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_task_runner.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_task_runner.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gl_surface_adapter.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gl_surface_adapter.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_impl.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_impl.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_memory_tracker.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_memory_tracker.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_state.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_state.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/ozone_gpu_memory_buffer.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/ozone_gpu_memory_buffer.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/BUILD.gn
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/lib/gles2_context.cc
[rename] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/lib/raster_thread_helper.cc
[rename] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/raster_thread_helper.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/service.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/service.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/BUILD.gn
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/direct_output_surface_ozone.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/display_compositor.h
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc
[delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/surfaces_context_provider.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/surfaces_context_provider.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/BUILD.gn
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/window_tree_host_factory.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/BUILD.gn
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/surface_context_factory.h

Comment 11 by roc...@chromium.org, Jul 27 2016

Blockedon: -631143

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99035fbb67293836944993268f0357ad3d65a4d

commit f99035fbb67293836944993268f0357ad3d65a4d
Author: sadrul <sadrul@chromium.org>
Date: Fri Jul 29 16:08:59 2016

services/ui: Revert CLs that broke Windows.

The new GPU code path does not seem to work correctly on Windows yet
(everything is black). So restore the deprecated path.

Revert "services/ui: Remove deprecated gpu code" crrev.com/408207
Revert "services/ui: Remove unused connector argument" crrev.com/408230

BUG= 623157 ,  630893 
TBR=ben@, piman@, penghuang@

Review-Url: https://codereview.chromium.org/2194893002
Cr-Commit-Position: refs/heads/master@{#408648}

[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/chrome/browser/ui/views/frame/browser_frame_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/login/login.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/screenlock/screenlock.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/navigation/view_impl.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/demo/mus_demo.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/BUILD.gn
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/DEPS
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/OWNERS
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local_client.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.h
[rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.cc
[rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/bitmap_uploader.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/context_provider.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/gles2_context.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/bitmap_uploader.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/context_provider.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/gles2_context.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/window_tree_host_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/window_manager_connection.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99035fbb67293836944993268f0357ad3d65a4d

commit f99035fbb67293836944993268f0357ad3d65a4d
Author: sadrul <sadrul@chromium.org>
Date: Fri Jul 29 16:08:59 2016

services/ui: Revert CLs that broke Windows.

The new GPU code path does not seem to work correctly on Windows yet
(everything is black). So restore the deprecated path.

Revert "services/ui: Remove deprecated gpu code" crrev.com/408207
Revert "services/ui: Remove unused connector argument" crrev.com/408230

BUG= 623157 ,  630893 
TBR=ben@, piman@, penghuang@

Review-Url: https://codereview.chromium.org/2194893002
Cr-Commit-Position: refs/heads/master@{#408648}

[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/chrome/browser/ui/views/frame/browser_frame_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/login/login.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/screenlock/screenlock.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/navigation/view_impl.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/demo/mus_demo.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/BUILD.gn
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/DEPS
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/OWNERS
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local_client.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.h
[rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.cc
[rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/bitmap_uploader.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/context_provider.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/gles2_context.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/bitmap_uploader.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/context_provider.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/gles2_context.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.h
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc
[add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/window_tree_host_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/BUILD.gn
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.cc
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.h
[modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/window_manager_connection.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc871196a78618383d59162bd01f124422d6e0ef

commit bc871196a78618383d59162bd01f124422d6e0ef
Author: sadrul <sadrul@chromium.org>
Date: Fri Jul 29 18:28:31 2016

services/ui: Fix new GPU code path on Windows.

Make sure the child window created by the GPU is actually added to the
toplevel window.

BUG= 623157 

Review-Url: https://codereview.chromium.org/2188403004
Cr-Commit-Position: refs/heads/master@{#408695}

[modify] https://crrev.com/bc871196a78618383d59162bd01f124422d6e0ef/services/ui/gpu/gpu_service_mus.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534

commit e53bd8b6b93acc586ac72c445a5c4f1ff7f32534
Author: sadrul <sadrul@chromium.org>
Date: Fri Jul 29 19:16:15 2016

Revert of services/ui: Revert CLs that broke Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2194893002/ )

Reason for revert:
crrev.com/408695 fixes the issue. So we can reland
these CLs.

Original issue's description:
> services/ui: Revert CLs that broke Windows.
>
> The new GPU code path does not seem to work correctly on Windows yet
> (everything is black). So restore the deprecated path.
>
> Revert "services/ui: Remove deprecated gpu code" crrev.com/408207
> Revert "services/ui: Remove unused connector argument" crrev.com/408230
>
> BUG= 623157 ,  630893 
> TBR=ben@, piman@, penghuang@
>
> Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d
> Cr-Commit-Position: refs/heads/master@{#408648}

TBR=ben@chromium.org,piman@chromium.org,penghuang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623157 ,  630893 

Review-Url: https://codereview.chromium.org/2196503003
Cr-Commit-Position: refs/heads/master@{#408710}

[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/chrome/browser/ui/views/frame/browser_frame_mus.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/compositor/mus_browser_compositor_output_surface.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/mash/login/login.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/mash/screenlock/screenlock.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/navigation/view_impl.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/BUILD.gn
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/gpu_service.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/gpu_service.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/switches.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/switches.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/demo/mus_demo.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/BUILD.gn
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/DEPS
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/OWNERS
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver_manager.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver_manager.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_impl.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_impl.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local_client.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_task_runner.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_task_runner.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gl_surface_adapter.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gl_surface_adapter.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_impl.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_impl.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_memory_tracker.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_memory_tracker.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_state.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_state.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/ozone_gpu_memory_buffer.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/ozone_gpu_memory_buffer.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/BUILD.gn
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/bitmap_uploader.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/context_provider.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/gles2_context.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/bitmap_uploader.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/context_provider.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/gles2_context.cc
[rename] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/raster_thread_helper.cc
[rename] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/raster_thread_helper.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/service.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/service.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/BUILD.gn
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/direct_output_surface_ozone.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/display_compositor.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/display_compositor.h
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc
[delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/surfaces_context_provider.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/surfaces_context_provider.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/BUILD.gn
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display_init_params.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display_init_params.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/window_tree_host_factory.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/BUILD.gn
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_binding.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_binding.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_context_factory.cc
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_context_factory.h
[modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/window_manager_connection.cc

Comment 16 by penghuang@chromium.org, Aug 2 2016

Owner: sadrul@chromium.org

sadrul, your CL has been re-landed. Is this issue fixed?

Comment 17 by sadrul@chromium.org, Aug 3 2016

Status: Fixed (was: Assigned)

►

Issue 623157 link

Issue metadata

Enable chrome GPU command buffer on Windows

Issue description

Comment 1 by sadrul@chromium.org, Jul 8 2016

Comment 1 Deleted

Comment 2 by staraz@chromium.org, Jul 11 2016

Comment 2 Deleted

Comment 3 by penghuang@chromium.org, Jul 11 2016

Comment 3 Deleted

Comment 4 by sadrul@chromium.org, Jul 11 2016

Comment 4 Deleted

Comment 5 by penghuang@chromium.org, Jul 11 2016

Comment 5 Deleted

Comment 6 by penghuang@chromium.org, Jul 13 2016

Comment 6 Deleted

Comment 7 by penghuang@chromium.org, Jul 13 2016

Comment 7 Deleted

Comment 8 by fsam...@chromium.org, Jul 25 2016

Comment 8 Deleted

Comment 9 by penghuang@chromium.org, Jul 25 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jul 27 2016

Comment 10 Deleted

Comment 11 by roc...@chromium.org, Jul 27 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 29 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 29 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 29 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 29 2016

Comment 15 Deleted

Comment 16 by penghuang@chromium.org, Aug 2 2016

Comment 16 Deleted

Comment 17 by sadrul@chromium.org, Aug 3 2016

Comment 17 Deleted

Sign in to add a comment