New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623152 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[usb_detect] Add lid close and lid close action for platform_ExternalUsbPeripheral

Project Member Reported by ka...@chromium.org, Jun 24 2016

Issue description

1) add calls for lid_close and lid_open based on servo controls (we used to do this long time ago) to the action_suspend and action_resume methods
 - pass a parameter 'use_lid' with True or False value to choose which way to suspend and resume
 - default value - use_lid=False

2) Add actions corresponding to lid close and lid open

2.a. In actions main loop(line 298) for lid_open action pass action_suspend(use_lid=true)

2.b Add few new control files with action_sequence like;
 - unplug,login,lid_close,lid_open
 - login,unplug,lid_close,lid_open
 - login,lid_close,lid_open

 

Comment 1 by ka...@chromium.org, Jun 24 2016

There should be a filter on what boards to run these tests - we'll do it through a label 'use_lid' we'll assign to the boards in lab.

Comment 2 by ka...@chromium.org, Jun 30 2016

Components: Test
Labels: -Pri-3 Pri-2
These tests should be added to 'usb_detect' test suite.

Comment 4 by ka...@chromium.org, Aug 11 2016

Status: Verified (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448

commit 1aef8ba4ba89bbd667f19046c1ed0b1f0be87448
Author: Sridhar Sonti <sontis@chromium.org>
Date: Thu Jun 30 22:19:11 2016

Added closelid and openlid actions to the test.

BUG= chromium:623152 
TEST=None

Change-Id: Ic09d3ad53dc66e152e3a84da03a8fa14f890e028
Reviewed-on: https://chromium-review.googlesource.com/357884
Commit-Ready: Sridhar Sonti <sontis@chromium.org>
Tested-by: Sridhar Sonti <sontis@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
(cherry picked from commit b91faa5611e549c6bbcc6797317361c72826ebec)
Reviewed-on: https://chromium-review.googlesource.com/380521
Reviewed-by: Sridhar Sonti <sontis@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448/server/site_tests/platform_ExternalUsbPeripherals/platform_ExternalUsbPeripherals.py
[add] https://crrev.com/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_unplug_openlid_plug
[add] https://crrev.com/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_plug_openlid
[add] https://crrev.com/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_openlid_plug
[add] https://crrev.com/1aef8ba4ba89bbd667f19046c1ed0b1f0be87448/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_openlid

Sign in to add a comment