Changing WebKit test expectations for new V8 semantics |
|||
Issue descriptionWebKit/LayoutTests/fast/canvas/webgl/webgl-array-invalid-range.js is checking for semantics which no longer match the ECMAScript spec. When we fixed V8 to match the current spec in https://bugs.chromium.org/p/v8/issues/detail?id=5124, this test broke. Rebasing.
,
Jun 25 2016
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b57d8f8d9e7c1a26f94c4715804c9457e27cd5cf commit b57d8f8d9e7c1a26f94c4715804c9457e27cd5cf Author: bakkot <bakkot@google.com> Date: Tue Jun 28 19:22:21 2016 Invalidate a WebKit test which is testing for the wrong semantics in TypedArray constructors. Fixing the semantics in V8 broke the test. See crrev.com/3f0ada1d84e8956213465cb30b48e66f83895e8f BUG= 623120 Review-Url: https://codereview.chromium.org/2098843002 Cr-Commit-Position: refs/heads/master@{#402511} [modify] https://crrev.com/b57d8f8d9e7c1a26f94c4715804c9457e27cd5cf/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 28 2016
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60236bcc191a774f0a1cb243b2dc8b3edfc122e9 commit 60236bcc191a774f0a1cb243b2dc8b3edfc122e9 Author: xidachen <xidachen@chromium.org> Date: Thu Oct 20 18:16:47 2016 Updated fast/canvas/webgl-array-invalid-ranges.html This test still assumes that the following command should throw an exception: var array = new TypedArray(null, 0, 0); The specs https://www.khronos.org/registry/typedarray/specs/latest/#TYPEDARRAYS doesn't say it should throw an exception. So we update this test. BUG= 623120 Review-Url: https://chromiumcodereview.appspot.com/2433363003 Cr-Commit-Position: refs/heads/master@{#426533} [modify] https://crrev.com/60236bcc191a774f0a1cb243b2dc8b3edfc122e9/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/60236bcc191a774f0a1cb243b2dc8b3edfc122e9/third_party/WebKit/LayoutTests/fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt [modify] https://crrev.com/60236bcc191a774f0a1cb243b2dc8b3edfc122e9/third_party/WebKit/LayoutTests/fast/canvas/webgl/webgl-array-invalid-ranges.html |
|||
►
Sign in to add a comment |
|||
Comment 1 by bakkot@google.com
, Jun 24 2016Status: Started (was: Untriaged)