New issue
Advanced search Search tips

Issue 623117 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Make chooser action button use blue background

Project Member Reported by rolfe@chromium.org, Jun 24 2016

Issue description

Users are trying to tap "Pair" on chooser dialogs without selecting an item. They don't notice the button (plain blue text on white background) is faded out.
Current spec: https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEclJiQmZTbHJ4X00/view 

The request is to change the button style to be white text on a blue button so it's easier to see it's faded out. This matches proposed changes for settings.
https://drive.google.com/a/google.com/file/d/0B-TxIvn0COW1eWd2VWtRSmM0YjA/view

---

Desktop
Note UI in this space is undergoing a lot of discussion about best styling across platforms. Latest styling is here:
https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEUjB6S0J1MGU3aEE/view
And for a positioning example:
https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEdkJmU3NHZU03UHc/view
Bettes@ is OOO but could weigh in on any newer thinking in a couple weeks (mid-July.) I think it mostly impacts Mac.

Mobile Android
This style already exists in clearing history (deselect all checkboxes to see gray button.) Do you need a spec or can you follow that?
Positioning example here:
https://drive.google.com/a/google.com/file/d/0B63LqjsMmAX_OHloRVdnbjlZRU0/view

 

Comment 1 by juncai@chromium.org, Jun 27 2016

Cc: fbeaufort@chromium.org
Owner: juncai@chromium.org

Comment 2 by juncai@chromium.org, Jun 27 2016

pair_button_1.png
124 KB View Download
pair_button_2.png
62.8 KB View Download

Comment 3 by juncai@chromium.org, Jun 27 2016

Status: Started (was: Assigned)

Comment 4 by rolfe@chromium.org, Jun 27 2016

Looks spiffy!!
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab04565a023ea70f5a4e424bef70bbb97336b40d

commit ab04565a023ea70f5a4e424bef70bbb97336b40d
Author: juncai <juncai@chromium.org>
Date: Tue Jun 28 00:40:45 2016

Change chooser action button to use grey and blue background

Sometimes users are trying to tap "PAIR" on WebBluetooth
chooser dialogs without selecting an item. This CL changes
the button to use grey background when no item is selected
and use blue background when an item is selected. This
makes it easier to see if the button is faded out or not.

I attached two screenshots of the chooser with grey and
blue background button in the issue link.

BUG= 623117 

Review-Url: https://codereview.chromium.org/2107583002
Cr-Commit-Position: refs/heads/master@{#402346}

[modify] https://crrev.com/ab04565a023ea70f5a4e424bef70bbb97336b40d/chrome/android/java/res/layout/item_chooser_dialog.xml

Comment 6 by juncai@chromium.org, Jun 29 2016

Status: Fixed (was: Started)

Sign in to add a comment