New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623105 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug

Blocked on:
issue 623142



Sign in to add a comment

smoothness.tough_canvas_cases benchmark failing on Windows and Mac Perf bots.

Project Member Reported by pras...@chromium.org, Jun 24 2016

Issue description

junov@ Do you thinks that
https://chromium.googlesource.com/chromium/src/+/33732aec33c88cb18c212544da7d0a4ba53cd9ce might have cause these failures?
Labels: OS-Mac
Summary: smoothness.tough_canvas_cases benchmark failing on Windows and Mac Perf bots. (was: smoothness.tough_canvas_cases benchmark failing on Windows Perf bots.)
This is also failing on Mac
https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20(3)
https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%283%29?numbuilds=50
Blockedon: 623142
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582209c397ef25fb75bd8fdf58ff74c291172247

commit 582209c397ef25fb75bd8fdf58ff74c291172247
Author: prasadv <prasadv@chromium.org>
Date: Sat Jun 25 11:16:30 2016

Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots.

BUG= 623105 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2097923002
Cr-Commit-Position: refs/heads/master@{#402060}

[modify] https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247/tools/perf/benchmarks/smoothness.py

Labels: Performance-Sheriff-BotHealth

Comment 7 by junov@chromium.org, Jul 29 2016

Status: Assigned (was: Untriaged)
https://chromium.googlesource.com/chromium/src/+/33732aec33c88cb18c212544da7d0a4ba53cd9ce

was reverted because it was causing crashes.  It should be safe to re-enable the tests now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb8a86535c3e3e55ec5ab14626df6fbee610262

commit 9bb8a86535c3e3e55ec5ab14626df6fbee610262
Author: junov <junov@chromium.org>
Date: Fri Jul 29 21:24:21 2016

Revert of Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots. (patchset #1 id:1 of https://codereview.chromium.org/2097923002/ )

Reason for revert:
Regression was reverted, so tests can be re-enabled

Original issue's description:
> Disabled smoothness.tough_canvas_cases benchmark on Win and Mac perf bots.
>
> BUG= 623105 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/582209c397ef25fb75bd8fdf58ff74c291172247
> Cr-Commit-Position: refs/heads/master@{#402060}

TBR=eakuefner@chromium.org,sullivan@chromium.org,prasadv@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 623105 

Review-Url: https://codereview.chromium.org/2191413002
Cr-Commit-Position: refs/heads/master@{#408764}

[modify] https://crrev.com/9bb8a86535c3e3e55ec5ab14626df6fbee610262/tools/perf/benchmarks/smoothness.py

Status: Fixed (was: Assigned)
Looks like this is fixed, so I'll go ahead and mark it as such. If it's still a problem, feel free to reopen.

Sign in to add a comment