New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623100 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cryptohome: integrate with tpm_managerd for tpm2 status

Project Member Reported by dkrahn@chromium.org, Jun 24 2016

Issue description

Cryptohome support for TPM2 needs to be integrated with tpm_managerd to have authoritative TPM status data.
 

Comment 1 by dkrahn@chromium.org, Jun 28 2016

Cc: smbar...@chromium.org
Owner: dkrahn@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/429117685e092edadae6714c1fb495fedd44d877

commit 429117685e092edadae6714c1fb495fedd44d877
Author: Darren Krahn <dkrahn@google.com>
Date: Tue Jun 28 22:08:14 2016

tpm_manager: Create static lib for test code useful externally.

BUG= chromium:623100 
TEST=build, use with cryptohome unit tests

Change-Id: I78f637cc0817c6e03ec210b0c983dfa1b8b00686
Reviewed-on: https://chromium-review.googlesource.com/356664
Commit-Ready: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/429117685e092edadae6714c1fb495fedd44d877/tpm_manager/common/mock_tpm_ownership_interface.cc
[modify] https://crrev.com/429117685e092edadae6714c1fb495fedd44d877/tpm_manager/common/mock_tpm_nvram_interface.cc
[modify] https://crrev.com/429117685e092edadae6714c1fb495fedd44d877/tpm_manager/tpm_manager.gyp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/849c6edbdd1a6d0b4f3c73279485126bd1136665

commit 849c6edbdd1a6d0b4f3c73279485126bd1136665
Author: Darren Krahn <dkrahn@google.com>
Date: Wed Jun 29 00:54:51 2016

tpm_manager: Moved all object initialization onto worker thread.

The dbus proxy must be owned by a single thread so the initialization
and use need to happen on the same thread.

Also fixed unit tests.

BUG= chromium:623100 
TEST=unit, manual with tpm2 simulator

Change-Id: I206f6ee59beef2685c3cae13e59b0e7a45098329
Reviewed-on: https://chromium-review.googlesource.com/356840
Commit-Ready: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/849c6edbdd1a6d0b4f3c73279485126bd1136665/tpm_manager/server/tpm_manager_service.cc
[modify] https://crrev.com/849c6edbdd1a6d0b4f3c73279485126bd1136665/tpm_manager/server/tpm_manager_service.h
[modify] https://crrev.com/849c6edbdd1a6d0b4f3c73279485126bd1136665/tpm_manager/tpm_manager.gyp
[modify] https://crrev.com/849c6edbdd1a6d0b4f3c73279485126bd1136665/tpm_manager/server/tpm_manager_service_test.cc
[modify] https://crrev.com/849c6edbdd1a6d0b4f3c73279485126bd1136665/tpm_manager/server/main.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b4d236a47ce4d7e1034d503c25db47880fbfeef7

commit b4d236a47ce4d7e1034d503c25db47880fbfeef7
Author: Darren Krahn <dkrahn@google.com>
Date: Wed Jun 29 00:58:36 2016

tpm_manager: Install all headers and the test lib.

BUG= chromium:623100 
TEST=build, integrate with cryptohome

Change-Id: I2193c65f169acbf22a9aff0d525b959a2b3e5414
Reviewed-on: https://chromium-review.googlesource.com/356910
Commit-Ready: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/b4d236a47ce4d7e1034d503c25db47880fbfeef7/chromeos-base/tpm_manager/tpm_manager-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/tpm/+/6cbcd73e9315cc68605024003aaa8f347ddd6615

commit 6cbcd73e9315cc68605024003aaa8f347ddd6615
Author: Andrey Pronin <apronin@google.com>
Date: Thu Jun 30 22:16:18 2016

trunks: set long reply timeout in dbus configuration

Set reply timeout in dbus for trunksd to 4 min. tpm_manager may
request to TakeOwnership, which may take 2-3 min. With default
dbus settings, tpm_manager gets a timeout while waiting on trunksd
to finish the operation.

BUG= chromium:623100 
TEST=Boot on kevin, do "tpm_manager_client take_ownership"

Change-Id: I13861da82ea83ca1f87cd726a2084eb53429e294
Reviewed-on: https://chromium-review.googlesource.com/357920
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>

[modify] https://crrev.com/6cbcd73e9315cc68605024003aaa8f347ddd6615/trunks/org.chromium.Trunks.conf

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/117f3e03fec35ee7ea6398aebed6cd6d9068b05f

commit 117f3e03fec35ee7ea6398aebed6cd6d9068b05f
Author: Darren Krahn <dkrahn@google.com>
Date: Mon Jun 27 23:15:33 2016

cryptohome: Integrate with tpm_managerd for tpm2 tasks.

TPM status, ownership, and nvram management are handled by tpm_managerd
for TPM 2.0 devices.

BUG= chromium:623100 
TEST=unit, manual with tpm2 simulator

Change-Id: I3815cc02320105609c75586d516114f8cd46669c
Reviewed-on: https://chromium-review.googlesource.com/356816
Commit-Ready: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>

[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/tpm2_impl.cc
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/attestation.cc
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/attestation_unittest.cc
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/tpm2_impl.h
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/tpm_impl.h
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/stub_tpm.h
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/cryptohome.gyp
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/tpm.h
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/mock_tpm.h
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/tpm2_test.cc
[modify] https://crrev.com/117f3e03fec35ee7ea6398aebed6cd6d9068b05f/cryptohome/lockbox-cache-tpm.h

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment