New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623077 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Windows] Re-enable 64-bit build checks for Windows binaries

Project Member Reported by joedow@chromium.org, Jun 24 2016

Issue description

In CL https://codereview.chromium.org/2096513002, all of the Windows binaries were defined as 32-bit only.  I don't think this is what we want.

We should define the packages as being 32-bit only, but I think it is important to continue building and verifying the output for the 64-bit versions of our binaries.


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c262ad93cafd49ced3e82bc907b6fe0a042b6a59

commit c262ad93cafd49ced3e82bc907b6fe0a042b6a59
Author: zijiehe <zijiehe@chromium.org>
Date: Tue Oct 11 00:53:16 2016

[Chromoting] Reenable 64-bit build checks for Windows

After discussing with team members, we prefer to keep generating 64 bit host archive.

BUG= 623077 

TBR=mmoss@chromium.org

Review-Url: https://codereview.chromium.org/2403923003
Cr-Commit-Position: refs/heads/master@{#424314}

[modify] https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59/chrome/tools/build/win/FILES.cfg

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0863beb9eecda857d9dd79e653d5975b53ebf8c1

commit 0863beb9eecda857d9dd79e653d5975b53ebf8c1
Author: alph <alph@chromium.org>
Date: Tue Oct 11 19:06:07 2016

Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ )

Reason for revert:
Speculative revert for possibly causing a failure of official build. See crbug.com/654818

Original issue's description:
> [Chromoting] Reenable 64-bit build checks for Windows
>
> After discussing with team members, we prefer to keep generating 64 bit host archive.
>
> BUG= 623077 
>
> TBR=mmoss@chromium.org
>
> Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59
> Cr-Commit-Position: refs/heads/master@{#424314}

TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623077 

Review-Url: https://codereview.chromium.org/2405253003
Cr-Commit-Position: refs/heads/master@{#424503}

[modify] https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1/chrome/tools/build/win/FILES.cfg

Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cecf7722096a54885fa1c620f0ee34b54b56c741

commit cecf7722096a54885fa1c620f0ee34b54b56c741
Author: zijiehe <zijiehe@chromium.org>
Date: Tue Oct 18 21:03:54 2016

Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ )

Reason for revert:
Resubmit original change https://codereview.chromium.org/2403923003/.

Original issue's description:
> Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ )
>
> Reason for revert:
> Speculative revert for possibly causing a failure of official build. See crbug.com/654818
>
> Original issue's description:
> > [Chromoting] Reenable 64-bit build checks for Windows
> >
> > After discussing with team members, we prefer to keep generating 64 bit host archive.
> >
> > BUG= 623077 
> >
> > TBR=mmoss@chromium.org
> >
> > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59
> > Cr-Commit-Position: refs/heads/master@{#424314}
>
> TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 623077 
>
> Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1
> Cr-Commit-Position: refs/heads/master@{#424503}

TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623077 

Review-Url: https://codereview.chromium.org/2405413002
Cr-Commit-Position: refs/heads/master@{#426044}

[modify] https://crrev.com/cecf7722096a54885fa1c620f0ee34b54b56c741/chrome/tools/build/win/FILES.cfg

Status: Fixed (was: Started)

Sign in to add a comment