[perf] Add browser logs to system health benchmarks |
||||||
Issue descriptionAs explained in https://groups.google.com/a/chromium.org/forum/?pli=1#!topic/telemetry/l94bj9U57N0, I propose we enable browser logging on perf bots (--enable-logging runtime flag) to simplify triaging flakes on the perf waterfall (https://build.chromium.org/p/chromium.perf/console).
,
Jun 28 2016
The correct bug link in the previous comment should have been https://bugs.chromium.org/p/chromium/issues/detail?id=623910.
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a29030040dff42fe4dc0317d81f49bdaf80f1185 commit a29030040dff42fe4dc0317d81f49bdaf80f1185 Author: petrcermak <petrcermak@chromium.org> Date: Wed Jun 29 12:37:35 2016 [perf] Enable non-verbose logging in memory system health benchmarks Rationale: To help triage flakes on the perf waterfall. BUG= 623058 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Review-Url: https://codereview.chromium.org/2094143005 Cr-Commit-Position: refs/heads/master@{#402784} [modify] https://crrev.com/a29030040dff42fe4dc0317d81f49bdaf80f1185/tools/perf/benchmarks/system_health.py
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f24b374d53e9d99b782832dc3703faeff9774ca6 commit f24b374d53e9d99b782832dc3703faeff9774ca6 Author: petrcermak <petrcermak@chromium.org> Date: Wed Jun 29 22:43:34 2016 [telemetry] Replace enable_logging usage with logging_verbosity This patch replaces the only usage of BrowserOptions.enable_logging with BrowserOptions.logging_verbosity. Context: https://codereview.chromium.org/2093923002/ BUG= 623058 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2100253002 Cr-Commit-Position: refs/heads/master@{#402972} [modify] https://crrev.com/f24b374d53e9d99b782832dc3703faeff9774ca6/content/test/gpu/gpu_tests/trace_test.py
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f24850ea0b9b4b4a8573c97f11758507e22ebde commit 5f24850ea0b9b4b4a8573c97f11758507e22ebde Author: rbyers <rbyers@chromium.org> Date: Thu Jul 07 17:44:14 2016 Revert of [perf] Enable non-verbose logging in memory system health benchmarks (patchset #3 id:60001 of https://codereview.chromium.org/2094143005/ ) Reason for revert: Seeing system_health.memory_desktop failures on Windows. petrcermak@ says this CL is the likely culprit and should be reverted. https://bugs.chromium.org/p/chromium/issues/detail?id=625172 Original issue's description: > [perf] Enable non-verbose logging in memory system health benchmarks > > Rationale: To help triage flakes on the perf waterfall. > > BUG= 623058 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/a29030040dff42fe4dc0317d81f49bdaf80f1185 > Cr-Commit-Position: refs/heads/master@{#402784} TBR=nednguyen@google.com,perezju@chromium.org,primiano@chromium.org,petrcermak@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 623058 Review-Url: https://codereview.chromium.org/2124333002 Cr-Commit-Position: refs/heads/master@{#404174} [modify] https://crrev.com/5f24850ea0b9b4b4a8573c97f11758507e22ebde/tools/perf/benchmarks/system_health.py
,
Jul 7 2016
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104d1e7a0e23f9e7a9fb5572026580a98d2944c0 commit 104d1e7a0e23f9e7a9fb5572026580a98d2944c0 Author: petrcermak <petrcermak@chromium.org> Date: Fri Jul 08 16:09:41 2016 [system-health] Enable browser logging in the smoke test BUG= 623058 , 625172 Review-Url: https://codereview.chromium.org/2133093002 Cr-Commit-Position: refs/heads/master@{#404403} [modify] https://crrev.com/104d1e7a0e23f9e7a9fb5572026580a98d2944c0/tools/perf/benchmarks/system_health_smoke_test.py
,
Jul 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cffff985306c9404f210edc29480305bbc3234c2 commit cffff985306c9404f210edc29480305bbc3234c2 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Sat Jul 09 19:10:26 2016 Roll src/third_party/catapult/ 243e3dfbc..6cad5da3c (12 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/243e3dfbc911..6cad5da3c39e $ git log 243e3dfbc..6cad5da3c --date=short --no-merges --format='%ad %ae %s' BUG= 625363 ,531641,472699, 623058 ,472699, 625852 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2136803002 Cr-Commit-Position: refs/heads/master@{#404566} [modify] https://crrev.com/cffff985306c9404f210edc29480305bbc3234c2/DEPS
,
Jul 21 2016
This is fixed with Petr's CL in #7
,
Jul 21 2016
,
Jul 21 2016
The plan is to add this to the memory system health benchmark itself as well.
,
Aug 15 2016
We decided to only enable logging in in SH smoke tests on the CQ. These should catch pretty much all failures that could happen in the benchmarks.
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d44ebe6c88dbce694e2cdce41c5bd12246ce1e4 commit 3d44ebe6c88dbce694e2cdce41c5bd12246ce1e4 Author: petrcermak <petrcermak@chromium.org> Date: Mon Aug 22 13:41:12 2016 [system-health] Actually enable browser logging in smoke test It turns out that the original patch (https://codereview.chromium.org/2133093002) didn't actually enable browser logging in the System Health smoke tests. BUG= 623058 , 639538 Review-Url: https://codereview.chromium.org/2267663003 Cr-Commit-Position: refs/heads/master@{#413437} [modify] https://crrev.com/3d44ebe6c88dbce694e2cdce41c5bd12246ce1e4/tools/perf/benchmarks/system_health_smoke_test.py
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba4975444436dcc36359d9b54043549f1eb9b809 commit ba4975444436dcc36359d9b54043549f1eb9b809 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Sep 01 14:26:47 2016 Roll src/third_party/catapult/ 9a90934eb..99d66b408 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9a90934ebf06..99d66b4084d0 $ git log 9a90934eb..99d66b408 --date=short --no-merges --format='%ad %ae %s' 2016-09-01 petrcermak [telemetry] Remove deprecated --enable-browser-logging flag BUG= 623058 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2297363005 Cr-Commit-Position: refs/heads/master@{#415949} [modify] https://crrev.com/ba4975444436dcc36359d9b54043549f1eb9b809/DEPS |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by petrcermak@chromium.org
, Jun 28 2016