Ninja not rebuilding apk when source file changes |
||
Issue descriptionI believe this affects only component build. Steps: 1) build system_webview_apk 2) add a line in chrome/renderer/chrome_render_view_observer.cc 3) build system_webview_apk Notice that libwebviewchromium.cr.so is rebuilt, but then the apk is not. Best guess at CL that broke this: https://codereview.chromium.org/2082453003
,
Jun 24 2016
doh! Yeah, pasted the wrong path there. It was a file in android_webview/ that I had touched to test this. Fix is here: https://codereview.chromium.org/2091303002/
,
Jun 24 2016
with that CL, it seems somethings are rebuilt even if I don't touch anything.. says it executed 142 steps for system_webview_apk
,
Jun 24 2016
definitely better than wrong build though
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f762d1c3e6b31608f4c5017dbceacd0e54115e0b commit f762d1c3e6b31608f4c5017dbceacd0e54115e0b Author: agrieve <agrieve@chromium.org> Date: Fri Jun 24 16:16:38 2016 Fix missing ninja dependency between .apk and component shared libs BUG= 623054 Review-Url: https://codereview.chromium.org/2091303002 Cr-Commit-Position: refs/heads/master@{#401870} [modify] https://crrev.com/f762d1c3e6b31608f4c5017dbceacd0e54115e0b/build/android/gyp/apkbuilder.py
,
Jun 24 2016
Just tried typing "ninja system_webview_apk" twice in a row, and the second time it reported: ninja: no work to do. If that's not the case, there's probably some other bug going on.
,
Jun 24 2016
my args.gn: """ target_os = "android" target_cpu = "arm" dcheck_always_on = true is_debug = false is_component_build = true is_clang = true symbol_level = 1 system_webview_package_name = "com.google.android.webview" run_findbugs = false use_goma = false """ synced to r401888, ie past the fix, and building now, let's see after it builds..
,
Jun 24 2016
that's weird, first clean build did 50 steps, then subsequent ones are "no work to do"..
,
Jun 24 2016
and now I can't repro it at all on r401888, so nevermind..
,
Jun 24 2016
original bug is fixed |
||
►
Sign in to add a comment |
||
Comment 1 by boliu@chromium.org
, Jun 24 2016