Netlog sometimes doesn't contain network change events |
||
Issue descriptionVersion: ToT OS: Android NetLogWithNetworkChangeEvents's constructor creates a net::LoggingNetworkChangeObserver which registers with the NetworkChangeNotifier for change events. Unfortunately this can happen before the NetworkChangeNotifier is created in which case NetworkChangeNotifier::AddNetworkChangeObserver() silently does nothing because there is no NCN to register with.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03226f05445777d5b15f9a33f47cf43abb8d06c3 commit 03226f05445777d5b15f9a33f47cf43abb8d06c3 Author: pauljensen <pauljensen@chromium.org> Date: Mon Jun 27 12:42:07 2016 [Cronet] Fix race with NetLogWithNetworkChangeEvents registration with NCN The NetLogWithNetworkChangeEvents needs to wait to register with the NetworkChangeNotifier until it is created, otherwise registration silently fails and the NetLog does not contain network change events. BUG= 623037 R=xunjieli Review-Url: https://codereview.chromium.org/2098753002 Cr-Commit-Position: refs/heads/master@{#402155} [modify] https://crrev.com/03226f05445777d5b15f9a33f47cf43abb8d06c3/components/cronet/android/cronet_url_request_context_adapter.cc
,
Jun 27 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by pauljensen@chromium.org
, Jun 24 2016