New issue
Advanced search Search tips
Starred by 23 users
Status: Duplicate
Merged: issue 21438
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment
Title bar button layout out of sync on XFCE
Reported by xiaqq...@gmail.com, Nov 8 2010 Back to list
Chrome Version       : 8.0.552.28 (Developer Build 64647) Ubuntu 10.10
URLs (if applicable) : none
Other browsers tested: none

What steps will reproduce the problem?
1. Run XFCE 4 Settings Manager and navigate to Window Manager. Change the title bar button layout to some non-vanilla style. I changed it to the Mac style used by Ubuntu 10.10.
2. Run Chromium.

What is the expected result?
Title bar button layout should stay in sync with the settings of XFCE.

What happens instead?
The buttons still appear on the right.

Please provide any additional information below. Attach a screenshot if
possible.
Chromium is currently able to stay in sync with the settings of GNOME. Some similar codes for XFCE is required.
The screenshot shows the Window Manager section of XFCE 4 Settings Manager and Chromium. The contrary of button layouts should be obvious.
 
chromium_xfce.png
120 KB View Download
Labels: not-sync
Comment 2 by e...@chromium.org, Aug 24 2011
 Issue 90307  has been merged into this issue.
Comment 3 by e...@chromium.org, Aug 24 2011
Cc: e...@chromium.org
Labels: -Type-Bug -Area-Undefined -not-sync Type-Feature Area-UI OS-Linux Feature-Browser
Status: Available
Comment 4 by Deleted ...@, Jan 20 2012
I'm having the same issue.
In Unity, the buttons were on the left. In xfce there aren't. So there must be some way to make it work in xfce as well.
issue still exists in XFCE 4.10
Labels: Action-FeedbackNeeded
Some questions:
- What version of XFCE are you guys using?
- Where is the button layout setting stored on your version?
- Is this setting documented anywhere on XFCE's website?
Comment 8 by csenge...@gmail.com, Jun 11 2012
- XFCE 4.10
- It is stored in "/usr/share/themes/<theme_name>/xfwm4/themerc" file under "button_layout=" line.
- It is documented at http://wiki.xfce.org/howto/xfwm4_theme#themerc_file

The tricky thing is that not all themerc file of the themes include this button_layout line, some are missing it.
So when the user customizes the button order as seen in chromium_xfce.png above, where does that get saved to? I doubt users can write to /usr/share/themes/<theme_name>/xfwm4/themerc directly.

There's also the question of how to find out what the current selected theme is.

Thanks for answering these questions BTW.
I've also found and article here: http://xubuntugeek.blogspot.hu/2011/11/window-buttons-on-left-side-xubuntu.html
Stating that with CLI command
xfconf-query -c xfwm4 -p /general/button_layout -s "CMH|O"
you can set the window buttons to a desired order, where the characters at the end explained at http://wiki.xfce.org/howto/xfwm4_theme#themerc_file

Though, I am not able to understand that CLI command, trying to find someone who can give the exact location of the file that that command modifies.
Found it, or at least I hope I managed to:

~/.config/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml

<property name="button_layout" type="string" value="CMH|S"/>
Comment 12 by wzybo...@gmail.com, Jun 12 2012
Yes, you can set the Windows button order in xfwm4.xml or the theme file, but the Chromium just does not follow it.
cr-doesnot-follow-xfwm4-button-layout.png
249 KB View Download
Labels: -Action-FeedbackNeeded
Owner: thestig@chromium.org
Status: Assigned
Thanks for all the info. I'll try to fix it this week.
I can confirm that ~/.config/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml has the button_layout changed when I use XFCE settings manager to change window buttons. I know this is a minor issue, but I'm very excited to see that it may be fixed soon. Thanks!
Watching for changes to the config file works, but the other windows gets the button order reconfiguration updates faster. It looks like they might be listening over DBUS.
I was wondering if this change was pushed to the current google-chrome dev channel version (23.0.1271.10 dev). It seems it's not working yet.
Screenshot_20121001_223909.png
115 KB View Download
More than two years later, obviously this change was not pushed.
xfce-chromium-button-layout-20121002.png
285 KB View Download
Sorry folks, been busy with other things. I'll try to revisit the bug this week.
Project Member Comment 19 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Browser Cr-UI-Browser-Core Cr-UI
Comment 20 by Deleted ...@, Apr 30 2013
I hope this little bug will be fixed soon too beacause is always exist in Version 25.0.1364.160 (Xubuntu 12.10)
Hello, any chance this issue gets a fix? It's been 2 years and 7 months.
Comment 22 by wzybo...@gmail.com, Jun 22 2013
Hope this bug will eventually get fixed since someof the developers had already found out why long ago but just forgot to push the changes into the source code tree...
Hi there! More than 3 years passed, could you please push the changes to source tree?
Comment 24 by ch...@igalia.com, Mar 17 2014
After monitoring with dbus-monitor the result the operation of changing the button_layout property with the xfce4-settings-editor launches several D-bus messages.

Here there are the messages reported by dbus-monitor

method call sender=:1.77 -> dest=org.xfce.Xfconf serial=90 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=IsPropertyLocked
   string "xfwm4"
   string "/general/button_layout"
method return sender=:1.1 -> dest=:1.77 reply_serial=90
   boolean false
method call sender=:1.77 -> dest=org.xfce.Xfconf serial=91 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=SetProperty
   string "xfwm4"
   string "/general/button_layout"
   variant       string "O|SMHC"
method call sender=:1.77 -> dest=org.xfce.Xfconf serial=92 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=IsPropertyLocked
   string "xfwm4"
   string "/general/button_layout"
method return sender=:1.1 -> dest=:1.77 reply_serial=91
method return sender=:1.1 -> dest=:1.77 reply_serial=92
   boolean false
signal sender=:1.1 -> dest=(null destination) serial=309 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=PropertyChanged
   string "xfwm4"
   string "/general/button_layout"
   variant       string "O|SMHC"
method call sender=:1.77 -> dest=org.xfce.Xfconf serial=93 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=IsPropertyLocked
   string "xfwm4"
   string "/general/button_layout"
method call sender=:1.8 -> dest=org.xfce.Xfconf serial=22 path=/org/xfce/Xfconf; interface=org.xfce.Xfconf; member=GetProperty
   string "xfwm4"
   string "/general/margin_bottom"
method return sender=:1.1 -> dest=:1.77 reply_serial=93
   boolean false

Comment 25 by a...@guzman.io, Dec 12 2014
XFCE user here. Still no luck getting this in? :(
Cc: thestig@chromium.org
Components: -UI -UI>Browser>Core UI>Browser
Labels: -Pri-2 Pri-3
Owner: thomasanderson@chromium.org
https://codereview.chromium.org/11338028/ stalled out for whatever reason. I need to stop saying "I'll fix it this week" because some weeks are very long weeks.

thomasanderson: interested?
Status: Started
#26 Sure, I'll give it a try
Wait a second.. The buttons don't appear on the correct side on Unity.  I think we should probably fix that first
Screenshot from 2016-08-26 14:30:55.png
30.4 KB View Download
Huh. Well, I don't use Unity, and the right side is the right side. ;)
Labels: -Type-Feature Type-Bug
Mergedinto: 21438
Status: Duplicate
Duping into  bug 21438  because the fix for it (https://chromium-review.googlesource.com/c/chromium/src/+/636039) also addresses XFCE button layout.
Sign in to add a comment