New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623011 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD History: Keyboard arrow keys should navigate through history entries

Reported by dchau...@etouch.net, Jun 24 2016

Issue description

Chrome Version: 53.0.2778.0 (Official Build)1c74487d2fedacf44e9267e552b6575fc5a6ce11-refs/heads/master@{#401784} 32/64-bit.
OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS) 

Precondition: Navigate to 5-6 webpages such that history gets created in chrome://history page.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history page.
2. Press 'Tab' key such that focus reaches to checkbox/URL/more option icon.
3. Now press the down arrow from keyboard and observe.

Nothing happens on pressing the down arrow key from keyboard.
Focus should move to checkbox/URL/more option icon on pressing the down arrow key from keyboard.

This is a non-regression issue seen from M-50 series, as this is a new feature introduced from build # 50.0.2638.0 

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/50.0.2637.0..50.0.2638.0?pretty=fuller&n=100

Suspecting: r372589 ? 

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.3 MB View Download

Comment 1 by dchau...@etouch.net, Jun 24 2016

Labels: OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to repro the issue on mac 10.11 chrome version 53.0.2778.0
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 Deleted

Cc: calamity@chromium.org
Status: Available (was: Untriaged)
Summary: MD History: Keyboard arrow keys should navigate through history entries (was: Focus issue is observed ton chrome://history page.)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3

commit a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3
Author: calamity <calamity@chromium.org>
Date: Wed Sep 21 02:46:43 2016

[MD History] Add keyboard navigation to the main history list.

This CL adds arrow-key navigation to the main history list and makes a
single history item tab-navigable by using cr.ui.FocusRow and
iron-list's tab index property.

BUG= 623011 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2334553002
Cr-Commit-Position: refs/heads/master@{#419956}

[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/a1bc7bb78d1a777435f8aa73bdcd4eaae4eff8b3/ui/webui/resources/js/cr/ui/focus_row.js

Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment