New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622998 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Browser Crash is seen on clicking "CLEAR BROWSING DATA" Button for second time in chrome://md-settings

Project Member Reported by mm00333...@techmahindra.com, Jun 24 2016

Issue description

Version: 53.0.2778.0
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome -> Sign into profile
(2)Now Go to chrome://md-settings/advanced page -> Click on "CLEAR BROWSING DATA" Button-> Select "the past hour" option from drop down and  Click on "CLEAR BROWSING DATA" Button
(3)Now immediately close the overlay (Please refer Video)-> Now again open overlay and select any option (Ex: the past hour, the past day) -> click on "CLEAR BROWSING DATA" Button and observe browser crash


Expected: Browser Crash should not be seen on clicking "CLEAR BROWSING DATA" Button
Actual: Instead Browser Crash is seen 

Below is the Crash Id:
Crash ID Chrome (Server ID: 84e6e7bc00000000)

This is Regression Issue broken in M-51

Below is the  Bisect info:

Manual good and Bad Builds:
Good Build: 51.0.2674.0
Bad Build:  51.0.2675.0

Note: Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing Manual change log info.

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/51.0.2674.0..51.0.2675.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/1750873002 from Manual changelog

@dschuyler : Please feel free to re-assign if its not related to your change
 
Actual_Crash.ogv
3.0 MB View Download
able to reproduce the issue on windows 7 using chrome version 53.0.2778.0

Crash id  :: e88fcfe600000000

stack trace
==============
Thread 0 CRASHED [EXCEPTION_BREAKPOINT @ 0x000007fee087b5a4 ] MAGIC SIGNATURE THREAD
0x000007fee087b5a4	(chrome.dll -settings_clear_browsing_data_handler.cc:76 )	settings::ClearBrowsingDataHandler::HandleClearBrowsingData(base::ListValue const *)
0x000007fedf54b933	(chrome.dll -web_ui_impl.cc:235 )	content::WebUIImpl::ProcessWebUIMessage(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x000007fedf54af7b	(chrome.dll -web_ui_impl.cc:85 )	content::WebUIImpl::OnWebUISend(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x000007fedf54bd4c	(chrome.dll -ipc_message_templates.h:121 )	IPC::MessageT<ViewHostMsg_WebUISend_Meta,std::tuple<GURL,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,void,void ( content::WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)>(IPC::Message const *,content::WebUIImpl *,content::WebUIImpl *,void *,void ( content::WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &))
0x000007fedf54aec0	(chrome.dll -web_ui_impl.cc:68 )	content::WebUIImpl::OnMessageReceived(IPC::Message const &)
0x000007fedf4cab0d	(chrome.dll -web_contents_impl.cc:621 )	content::WebContentsImpl::OnMessageReceived(content::RenderViewHost *,content::RenderFrameHost *,IPC::Message const &)
0x000007fedf5f1f24	(chrome.dll -render_view_host_impl.cc:829 )	content::RenderViewHostImpl::OnMessageReceived(IPC::Message const &)
0x000007fedf4f2d64	(chrome.dll -render_widget_host_impl.cc:432 )	content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const &)
0x000007fedf540e26	(chrome.dll -render_process_host_impl.cc:1755 )	content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &)
0x000007fedf32d717	(chrome.dll -ipc_channel_proxy.cc:284 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x000007feded1c9fe	(chrome.dll -task_annotator.cc:51 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &)
0x000007fedecbea17	(chrome.dll -message_loop.cc:493 )	base::MessageLoop::RunTask(base::PendingTask const &)
0x000007fedecbfba1	(chrome.dll -message_loop.cc:624 )	base::MessageLoop::DoWork()
0x000007feded1d1a7	(chrome.dll -message_pump_win.cc:262 )	base::MessagePumpForUI::DoRunLoop()
0x000007feded1ce73	(chrome.dll -message_pump_win.cc:140 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x000007fedecf894f	(chrome.dll -run_loop.cc:35 )	base::RunLoop::Run()
0x000007fedfae0b62	(chrome.dll -chrome_browser_main.cc:1943 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x000007fee0919a2c	(chrome.dll -browser_main_runner.cc:155 )	content::BrowserMainRunnerImpl::Run()
0x000007fedf5278a8	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x000007fedec8b48e	(chrome.dll -content_main_runner.cc:785 )	content::ContentMainRunnerImpl::Run()
0x000007fedebc4875	(chrome.dll -chrome_main.cc:84 )	ChromeMain
0x000000013fec8b3e	(chrome.exe -main_dll_loader_win.cc:185 )	MainDllLoader::Launch(HINSTANCE__ *)
0x000000013fec2b5b	(chrome.exe -chrome_exe_main_win.cc:262 )	wWinMain
0x000000013ff55a4d	(chrome.exe -exe_common.inl:255 )	__scrt_common_main_seh
0x7700f34c	(kernel32.dll + 0x0001f34c )	BaseThreadInitThunk
0x77142ca0	(ntdll.dll + 0x00032ca0 )	RtlUserThreadStart


Project Member

Comment 2 by sheriffbot@chromium.org, Jun 24 2016

Labels: FoundIn-M-53 Fracas
Users experienced this crash on the following builds:

Win Canary 53.0.2778.0 -  0.27 CPM, 1 reports, 1 clients (signature settings::ClearBrowsingDataHandler::HandleClearBrowsingData)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by dbeam@chromium.org, Jul 14 2016

Labels: -Fracas -M-54 -FoundIn-M-53 -MovedFrom-53
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b09ab93aed1759180313cec0ce435646b93225e

commit 3b09ab93aed1759180313cec0ce435646b93225e
Author: dbeam <dbeam@chromium.org>
Date: Thu Jul 14 18:18:42 2016

[MD settings] disable clear browsing data while it is running

This CL will disable the buttons in the clear browsing data dialog
if clear browsing data is in progress.

Based largely on https://crrev.com/2118503005/ by
Dave Schuyler <dschuyler@chromium.org>

BUG= 622998 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2133893002
Cr-Commit-Position: refs/heads/master@{#405518}

[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/browsing_data/browsing_data_remover.cc
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/browsing_data/browsing_data_remover.h
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
[modify] https://crrev.com/3b09ab93aed1759180313cec0ce435646b93225e/chrome/test/data/webui/settings/privacy_page_test.js

Comment 6 by dbeam@chromium.org, Jul 14 2016

Status: Fixed (was: Assigned)

Sign in to add a comment