New issue
Advanced search Search tips

Issue 622983 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

views_unittests StyledLabelTest.StyledRangeBold fails on Mac 10.10 (only)

Project Member Reported by tapted@chromium.org, Jun 24 2016

Issue description

Chrome Version       : 53.0.2774.3
OS Version: OS X 10.10.?

e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.10_rel_ng/builds/101009

Passes on the 10.9 bots, and passes for me locally on 10.12.

Error goes like

StyledLabelTest.StyledRangeBold (run #1):
[ RUN      ] StyledLabelTest.StyledRangeBold
../../ui/views/controls/styled_label_unittest.cc:296: Failure
Value of: styled()->child_count()
  Actual: 2
Expected: 3
[  FAILED  ] StyledLabelTest.StyledRangeBold (25 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce26dc83bff3f79f27b698f9cddeb7d9470949a

commit 1ce26dc83bff3f79f27b698f9cddeb7d9470949a
Author: tapted <tapted@chromium.org>
Date: Mon Jun 27 03:13:03 2016

Add views_unittests to Mac10.{9,9(dbg),10,11} and asan bots

Disable a few tests we haven't gotten to fixing yet, since it's more
important to get the rest into continuous integration at this point.

Will land this at a quiet time on the weekend, and monitor closely
for potential flakes or other problems.

Recently added tests disabled due to missing GetGlobalCapture()
implementation:
 - MenuRunnerTest.WidgetDoesntTakeCapture
 - WidgetTest.MousePressCausesCapture
 - WidgetTest.CaptureDuringMousePressNotOverridden

Disabled on 10.9 only (different native Textfield behaviour):
 - BridgedNativeWidgetTest.TextInput_MoveEditingCommands
 - BridgedNativeWidgetTest.TextInput_DeleteCommands

Also disables:
 - WidgetTest.FullscreenFrameLayout [fails only on bots]
 - StyledLabelTest.StyledRangeBold [fails only on 10.10]

But the other ~720 tests pass.

Disables tests for recent regressions in r401862 and r401987. We need
that continuous integration - stat!

BUG= 500806 ,  621734 ,  622979 ,  622983 ,  622979 ,  607403 ,  623420 ,  623421 

Review-Url: https://codereview.chromium.org/1925943002
Cr-Commit-Position: refs/heads/master@{#402103}

[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/cocoa/bridged_native_widget_unittest.mm
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/widget/widget_unittest.cc

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: karandeepb@chromium.org
Status: Started (was: Assigned)
This might have been resolved by r410525 "Mac: Fix PlatformFontMac::DeriveFont." as part of  Issue 605404  

CL to re-enable: https://codereview.chromium.org/2561463003
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30ab1e74491f83690c2e125c4a3e1b26c457583

commit e30ab1e74491f83690c2e125c4a3e1b26c457583
Author: tapted <tapted@chromium.org>
Date: Thu Dec 08 06:21:58 2016

MacViews: Re-enable StyledLabelTest.StyledRangeBold.

This was likely fixed after r410525 "Fix PlatformFontMac::DeriveFont".

BUG= 622983 

Review-Url: https://codereview.chromium.org/2561463003
Cr-Commit-Position: refs/heads/master@{#437196}

[modify] https://crrev.com/e30ab1e74491f83690c2e125c4a3e1b26c457583/ui/views/controls/styled_label_unittest.cc

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment