MacViews: Failing mouse capture views_unittests. |
|||
Issue descriptionThe following views_unittests are failing on MacViews- -WidgetTest.MousePressCausesCapture -WidgetTest.CaptureDuringMousePressNotOverridden -MenuRunnerTest.WidgetDoesntTakeCapture These were added in crrev.com/1953753002 and are caused because NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac is not implemented.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3ce4a9c327dcacf9a50792218fb79a794dae518 commit d3ce4a9c327dcacf9a50792218fb79a794dae518 Author: karandeepb <karandeepb@chromium.org> Date: Tue Jun 28 03:37:52 2016 MacViews: Fix failing mouse capture unittests. This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac. This was added in crrev.com/1953753002. This fixes the following three unittests which fail on MacViews: -WidgetTest.MousePressCausesCapture -WidgetTest.CaptureDuringMousePressNotOverridden -MenuRunnerTest.WidgetDoesntTakeCapture This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation which incorrectly returns the center point in screen coordinates while other EventGeneratorDelegateMac methods assume the window coordinates as the root coordinate system. This is needed for the three tests above to pass, since they don't specify an explicit event location for the EventGenerator. BUG= 622979 , 607403 Review-Url: https://codereview.chromium.org/2096993002 Cr-Commit-Position: refs/heads/master@{#402388} [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.h [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.mm [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_delegate.h [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_unittest.mm [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/controls/menu/menu_runner_unittest.cc [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/test/event_generator_delegate_mac.mm [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/native_widget_mac.mm [modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/widget_unittest.cc
,
Jun 28 2016
,
Jan 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 27 2016