New issue
Advanced search Search tips

Issue 622979 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Failing mouse capture views_unittests.

Project Member Reported by karandeepb@chromium.org, Jun 24 2016

Issue description

The following views_unittests are failing on MacViews-
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

These were added in crrev.com/1953753002 and are caused because NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac is not implemented.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce26dc83bff3f79f27b698f9cddeb7d9470949a

commit 1ce26dc83bff3f79f27b698f9cddeb7d9470949a
Author: tapted <tapted@chromium.org>
Date: Mon Jun 27 03:13:03 2016

Add views_unittests to Mac10.{9,9(dbg),10,11} and asan bots

Disable a few tests we haven't gotten to fixing yet, since it's more
important to get the rest into continuous integration at this point.

Will land this at a quiet time on the weekend, and monitor closely
for potential flakes or other problems.

Recently added tests disabled due to missing GetGlobalCapture()
implementation:
 - MenuRunnerTest.WidgetDoesntTakeCapture
 - WidgetTest.MousePressCausesCapture
 - WidgetTest.CaptureDuringMousePressNotOverridden

Disabled on 10.9 only (different native Textfield behaviour):
 - BridgedNativeWidgetTest.TextInput_MoveEditingCommands
 - BridgedNativeWidgetTest.TextInput_DeleteCommands

Also disables:
 - WidgetTest.FullscreenFrameLayout [fails only on bots]
 - StyledLabelTest.StyledRangeBold [fails only on 10.10]

But the other ~720 tests pass.

Disables tests for recent regressions in r401862 and r401987. We need
that continuous integration - stat!

BUG= 500806 ,  621734 ,  622979 ,  622983 ,  622979 ,  607403 ,  623420 ,  623421 

Review-Url: https://codereview.chromium.org/1925943002
Cr-Commit-Position: refs/heads/master@{#402103}

[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/cocoa/bridged_native_widget_unittest.mm
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/widget/widget_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3ce4a9c327dcacf9a50792218fb79a794dae518

commit d3ce4a9c327dcacf9a50792218fb79a794dae518
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Jun 28 03:37:52 2016

MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG= 622979 ,  607403 

Review-Url: https://codereview.chromium.org/2096993002
Cr-Commit-Position: refs/heads/master@{#402388}

[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_delegate.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_unittest.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/test/event_generator_delegate_mac.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/widget_unittest.cc

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment