rch: Before I go making CLs, is this a supported client? Can we remove this code if it's not being exercised by the waterfall at all?

It's a client used for testing the QUIC protocol, see https://www.chromium.org/quic/playing-with-quic.

I'm asking if it's still currently supported, given that it has no waterfall tests. If it isn't, we should delete the code, rather than fix (it's a 4 line fix).

Yes, it is a supported client which we use in the instructions here: http://www.chromium.org/quic/playing-with-quic

I don't think I understand the failure, though. The quic_client uses the same proof verifier that Chrome uses. And the quic_client is used in a number of tests (net/tools/quic_end_to_end_test.cc). Obviously, we don't have coverage that triggers this error, though. :> Can you say more?

Oh, the failure is that not policy enforcer is being passed into the proof verifier. I see. Hm. Yeah, we don't have waterfall tests of the actual client_bin.cc. Guess it's time to fix that.

err, s/not/no/

Hi,
I just started to play around QUIC. I have built quic_server/client as documented at http://www.chromium.org/quic/playing-with-quic and run the programs.
Then I got exactly same failure.

The root cause looks like that net::ProofVerifierChromium::ProofVerifierChromium() doesn't accept nullptr as CTPolicyEnforcer*.

In my case, the issue is resolved by the change as following:
$ git diff 
diff --git a/net/tools/quic/quic_simple_client_bin.cc b/net/tools/quic/quic_simple_client_bin.cc
index 04f95f4..d71ac90 100644
--- a/net/tools/quic/quic_simple_client_bin.cc
+++ b/net/tools/quic/quic_simple_client_bin.cc
@@ -252,9 +252,11 @@ int main(int argc, char* argv[]) {
   std::unique_ptr<TransportSecurityState> transport_security_state(
       new TransportSecurityState);
   std::unique_ptr<CTVerifier> ct_verifier(new MultiLogCTVerifier());
+  std::unique_ptr<net::CTPolicyEnforcer> ct_policy_enforcer(
+      new net::CTPolicyEnforcer());
   ProofVerifierChromium* proof_verifier = new ProofVerifierChromium(
-      cert_verifier.get(), nullptr, transport_security_state.get(),
-      ct_verifier.get());
+      cert_verifier.get(), ct_policy_enforcer.get(),
+      transport_security_state.get(), ct_verifier.get());
   net::QuicSimpleClient client(net::IPEndPoint(ip_addr, port), server_id,
                                versions, proof_verifier);
   client.set_initial_max_packet_length(

I'm landing a fix in https://codereview.chromium.org/2094413002/

RCH landed https://codereview.chromium.org/2094413002/ but I have no idea why Bugdroid didn't tell everyone.

Anyways, it should be fixed now?