New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622961 link

Starred by 1 user
Status: Duplicate
Merged: issue 400503
Owner: ----
Closed: Jun 2016
Cc:
mea...@chromium.org
█ f...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Improve chrome://interstitials unit tests

Project Member Reported by rsleevi@chromium.org, Jun 24 2016 
Version: 53.0.2777.0
OS: 7

What steps will reproduce the problem?
(1) Load chrome://interstitials
(2) Click link for an SSL error

What is the expected output?
(3) It doesn't crash

What do you see instead?
(3) It crashes

Please use labels and text to provide additional information.
reportid:b7c8c7bc00000000

Comment 1 by rsleevi@chromium.org, Jun 24 2016 

It's a regression caused by https://codereview.chromium.org/2084153003/ , which I'll work to fix.

However, it means there's no unittest coverage there for that flow. Hence this bug.

Comment 2 by rsleevi@chromium.org, Jun 24 2016

Labels: M-53

Comment 3 by rsleevi@chromium.org, Jun 24 2016

Summary: Improve chrome://interstitials unit tests (was: Improve interstitial unit tests)

Comment 4 by rsleevi@chromium.org, Jun 24 2016

Mergedinto: 400503
Status: Duplicate (was: Untriaged)
Ah, just saw that InterstitialUI
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38036ce8149c1ae43f76d78174d85febcceb9c76

commit 38036ce8149c1ae43f76d78174d85febcceb9c76
Author: rsleevi <rsleevi@chromium.org>
Date: Fri Jun 24 20:49:10 2016

Unbreak chrome://interstitials/ssl

https://crrev.com/401430 removed setting a certificate for the UI,
as it was believed to be unnecessary. As it turns out, it is necessary
to have a valid X509Certificate in the SSLInfo, and the unittests to
ensure that are disabled as flaky.

Unbreak this by minting a fake cert on the fly.

BUG= 526899 ,  622961 
TEST=Open chrome://interstitials/ssl and see that nothing explodes in a fashion Michael Bay begrudgingly approve of.
R=meacer@chromium.org

Review-Url: https://codereview.chromium.org/2090683004
Cr-Commit-Position: refs/heads/master@{#401960}

[modify] https://crrev.com/38036ce8149c1ae43f76d78174d85febcceb9c76/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/38036ce8149c1ae43f76d78174d85febcceb9c76/chrome/browser/ui/webui/interstitials/interstitial_ui.h

Comment 6 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment