New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622920 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Redirecting 'Questions? Contact us' link in Help App

Project Member Reported by mitsuji@chromium.org, Jun 23 2016

Issue description

Version 52.0.2743.49 beta (64-bit)
Platform 8350.38.0 (Official Build) beta-channel samus
Firmware Google_Samus.6300.174.0

Currently the 'Questions? Contact us' button points to Helpouts. We need to redirect this link to the contact page instead. In addition we need to prevent the dialog window for Helpouts from popping up. 


abodenha@ will allocate eng resources. Please re-assign when appropriate. 
 
Components: Platform>Apps>GetHelp
Status: Assigned (was: Unconfirmed)
Owner: ksangani@google.com
Cc: abod...@chromium.org rookrishna@chromium.org dhadd...@chromium.org sdantul...@chromium.org

Comment 4 by morsed@google.com, Sep 6 2016

Also, remove all code related to now-deprecated Real-Time Support (RTS)/Helpouts.

Comment 5 by morsed@google.com, Sep 13 2016

Cc: weifangsun@chromium.org
added weifangsun@ to CC list

Comment 6 by morsed@google.com, Sep 13 2016

Cc: morsed@google.com

Comment 7 by morsed@google.com, Sep 13 2016

ksangani@ provided me with the following URL for the Contact button, in order to point it to an online resource rather than open the RTS/Helpouts dialog as it historically has:

https://support.google.com/chromebook/answer/6250945?rd=2&source=genius-rts 

I presume the query string parameters "rd" and "source" are for tracking/metric purposes.  Are the values what we want to be using? Just thought I'd confirm before the new link is merged into upcoming release.

Comment 8 by morsed@google.com, Sep 14 2016

After conferring with answer content owner soudet@, "source" is not needed (it's appended automatically by chromebooks), and neither is "rd" (which in this case means there were two redirects before landing on that page).  A new parameter and unique value will be used for tracking purposes:
https://support.google.com/chromebook/answer/6250945?ctx=gethelpcontact 
Cc: -morsed@google.com
Labels: M-55
Owner: morsed@google.com

Comment 10 by morsed@google.com, Sep 28 2016

Labels: M-54
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c0d60853a51a88dff7f85770c47b2bce18b818

commit 30c0d60853a51a88dff7f85770c47b2bce18b818
Author: morsed <morsed@chromium.org>
Date: Mon Oct 03 20:51:53 2016

Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update.

Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp.

These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/

BUG= 622920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2376883002
Cr-Commit-Position: refs/heads/master@{#422520}

[modify] https://crrev.com/30c0d60853a51a88dff7f85770c47b2bce18b818/chrome/browser/resources/chromeos/genius_app/manifest.json
[modify] https://crrev.com/30c0d60853a51a88dff7f85770c47b2bce18b818/chrome/browser/resources/help_app/manifest.json

Comment 12 by morsed@google.com, Oct 3 2016

Labels: Merge-Request-54

Comment 13 by dimu@chromium.org, Oct 4 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
Labels: -Merge-Review-54 Merge-Approved-54
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 6 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/445f92bfbb12bc0924f81bf4488b4fe392888852

commit 445f92bfbb12bc0924f81bf4488b4fe392888852
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 06 19:56:18 2016

[Merge to M54] Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update.

Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp.

These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/

TBR=morsed@chromium.com, cylee@chromium.com, cnwan@chromium.com, xiyuan@chromium.com
BUG= 622920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2376883002
Cr-Commit-Position: refs/heads/master@{#422520}
(cherry picked from commit 30c0d60853a51a88dff7f85770c47b2bce18b818)

Review URL: https://codereview.chromium.org/2400793002 .

Cr-Commit-Position: refs/branch-heads/2840@{#666}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/445f92bfbb12bc0924f81bf4488b4fe392888852/chrome/browser/resources/chromeos/genius_app/manifest.json
[modify] https://crrev.com/445f92bfbb12bc0924f81bf4488b4fe392888852/chrome/browser/resources/help_app/manifest.json

Comment 16 by morsed@google.com, Oct 13 2016

Status: Fixed (was: Assigned)
Fixed.  Landed in M55, merged back into M54. 
Status: Verified (was: Fixed)
Verified on ChromeOS 8743.65.0 / 54.0.2840.59 beta
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/445f92bfbb12bc0924f81bf4488b4fe392888852

commit 445f92bfbb12bc0924f81bf4488b4fe392888852
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 06 19:56:18 2016

[Merge to M54] Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update.

Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp.

These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/

TBR=morsed@chromium.com, cylee@chromium.com, cnwan@chromium.com, xiyuan@chromium.com
BUG= 622920 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2376883002
Cr-Commit-Position: refs/heads/master@{#422520}
(cherry picked from commit 30c0d60853a51a88dff7f85770c47b2bce18b818)

Review URL: https://codereview.chromium.org/2400793002 .

Cr-Commit-Position: refs/branch-heads/2840@{#666}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/445f92bfbb12bc0924f81bf4488b4fe392888852/chrome/browser/resources/chromeos/genius_app/manifest.json
[modify] https://crrev.com/445f92bfbb12bc0924f81bf4488b4fe392888852/chrome/browser/resources/help_app/manifest.json

Sign in to add a comment