New issue
Advanced search Search tips

Issue 622915 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 79180



Sign in to add a comment

ietestcenter/css3/grid/grid-column-003.htm is flaky on WebKit Linux Leak

Project Member Reported by dgozman@chromium.org, Jun 23 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa2a1476f5bb37a192979135e5a7a4c7595dbcb

commit 1fa2a1476f5bb37a192979135e5a7a4c7595dbcb
Author: dgozman <dgozman@chromium.org>
Date: Fri Jun 24 02:10:09 2016

Disable ietestcenter/css3/grid/grid-column-003.htm on Linux Leak.

BUG= 622915 
TBR=rego@igalia.com

Review-Url: https://codereview.chromium.org/2096543003
Cr-Commit-Position: refs/heads/master@{#401787}

[modify] https://crrev.com/1fa2a1476f5bb37a192979135e5a7a4c7595dbcb/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by r...@igalia.com, Jun 27 2016

Blocking: 79180
Cc: svil...@igalia.com jfernan...@igalia.com
I don't know what's going on, we'd need to investigate it:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20563

Comment 3 by r...@igalia.com, Jul 8 2016

Labels: Needs-Feedback
@dgozman please could you tell me how to reproduce the Leak bot configuration?
Where can I find the GN/GYP variables it uses?

Thanks!

The test runs just fine in a regular build.

Comment 4 by r...@igalia.com, Jan 10 2017

Cc: cbiesin...@chromium.org e...@chromium.org
Coming back to this, it's a very simple test so it's really strange
it's the only one from all the Grid Layout tests that is leaking on Linux.
It's just a 2x2 grid container with 2 items in 1x1 cell.

As we cannot reproduce it and we didn't get any feedback about how to do it,
would be ok to remove it from TestExpectations and see if the issue appears again?

Comment 5 by e...@chromium.org, Dec 5 2017

Yes, let's give it a try.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0935af5345e6d007f7bd2bee7a7cc06d8f1f627b

commit 0935af5345e6d007f7bd2bee7a7cc06d8f1f627b
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed Dec 06 18:36:12 2017

[css-grid] Enable ietestcenter/css3/grid/grid-column-003.htm again

Remove ietestcenter/css3/grid/grid-column-003.htm from TestExpectations
as we didn't manage to reproduce the leak.
Let's see if the bots detect it again or it was already fixed.

BUG= 622915 

Change-Id: Ibd03c81d5074c6c73cf78abba3ef0abec07aea36
Reviewed-on: https://chromium-review.googlesource.com/809206
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#522144}
[modify] https://crrev.com/0935af5345e6d007f7bd2bee7a7cc06d8f1f627b/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by r...@igalia.com, Dec 11 2017

Status: WontFix (was: Assigned)
Closing this at this point that we've re-enabled the test
as we were not able to reproduce it.

Let's see if the issue appears again or not.

Sign in to add a comment