New issue
Advanced search Search tips

Issue 622903 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 403462
issue 617204



Sign in to add a comment

Add unittests for mojo CDM and Decryptor

Project Member Reported by xhw...@chromium.org, Jun 23 2016

Issue description

This is to track adding unit tests for MojoCdm, MojoCdmService, MojoDecryptor and MojoDecryptorService. The test should cover common scenarios and connection errors.

See https://codereview.chromium.org/2070753002 for an example to test MojoRenderer and MojoRendererService.

See issue 622901 for the bug to add tests for mojo AudioDecoder.
See  issue 622897  for the bug to add tests for mojo VideoDecoder.

 

Comment 1 by xhw...@chromium.org, Aug 26 2016

Cc: xhw...@chromium.org ddorwin@chromium.org
Labels: -Pri-3 M-55 Pri-2
MojoCdm is shipped on Cast and Android. We also plan to ship MojoDecryptor soon. It becomes more critical that we have proper test coverage on these classes. Bumping the priority and setting proper milestone.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 28 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-55 -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Most of the EME browser tests are running with the MojoCdm (in addition to pepper). However, the AesDecryptorTests should also have a Mojo variant, so keeping this issue open.

Comment 4 by xhw...@chromium.org, Aug 28 2017

We only have a few test cases in MojoDecryptorTest and we should add more before we launch mojo CDM on desktop.

As for AesDecryptorTests, it's a bit odd that we have to keep a mojo variant of it. We can discuss more on it.
Blocking: 403462
Labels: -Pri-2 M-65 Pri-1
Status: Assigned (was: Available)
It looks like we only have a few tests covering MojoDecryptor, mostly on resource release. We should add more tests to help catch bugs and prevent regression.
xhwang@ is this still p1, it doesn't seem to be actively worked on?
Labels: -Pri-1 -M-65 Pri-3

Sign in to add a comment